Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update settings aligned with gopls v0.10.0 #2486

Closed
hyangah opened this issue Sep 29, 2022 · 1 comment
Closed

Update settings aligned with gopls v0.10.0 #2486

hyangah opened this issue Sep 29, 2022 · 1 comment
Assignees
@hyangah
Labels
FrozenDueToAge
Milestone
v0.36.0

Comments

@hyangah
Copy link
Contributor

hyangah commented Sep 29, 2022 •
edited
Loading

gopls v0.10.0 will add deprecation notices

golang/go#55331
golang/go#55332
golang/go#55333

After v0.10.0-rc.1 is available

[x] Update settings.json
[x] Test whether the notice is sufficiently visible
[x] May need to temporarily disable the gopls setting check test
@hyangah hyangah added this to the v0.36.0 milestone Sep 29, 2022
@hyangah hyangah self-assigned this Sep 29, 2022
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/443155 mentions this issue: package.json: update gopls settings to match v0.10.0-pre.1

gopherbot pushed a commit that referenced this issue Oct 14, 2022
@hyangah
package.json: update gopls settings to match v0.10.0-pre.1
2e739cc 
And change tools/installtools (the script used to install tools
needed for running tests in CI) to query the latest version of gopls
(including prerelease) and install that version. This script change does not affect extension's behavior.


Updates #2486

Change-Id: I7c30904f59e7ab9694be3fc3b8e4f894138d3fa3
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/443155
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
@hyangah hyangah closed this as completed Oct 27, 2022
@golang golang locked and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hyangah hyangah

Labels
FrozenDueToAge
Projects
None yet
Milestone
v0.36.0
Development

No branches or pull requests
2 participants
@hyangah @gopherbot