Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug/elf: add DT_FLAGS_1 (dynamic flags) constants #56887

Closed
florinpapa opened this issue Nov 21, 2022 · 5 comments
Closed

debug/elf: add DT_FLAGS_1 (dynamic flags) constants #56887

florinpapa opened this issue Nov 21, 2022 · 5 comments
Assignees
@florinpapa
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge help wanted Proposal Proposal-Accepted
Milestone
Go1.21

Comments

@florinpapa
Copy link
Contributor

I propose defining constants for all ELF dynamic flags (pertaining to DT_FLAGS_1). This will help, for example, determining whether an object is a position-independent executable (PIE).

The following constants would be added and defined (according to Table 15-10 in https://docs.oracle.com/en/operating-systems/solaris/oracle-solaris/11.4/linkers-libraries/dynamic-section.html):

DF_1_NOW
DF_1_GROUP
DF_1_NODELETE
DF_1_LOADFLTR
DF_1_INITFIRST
DF_1_NOOPEN
DF_1_ORIGIN
DF_1_DIRECT
DF_1_INTERPOSE
DF_1_NODEFLIB
DF_1_ENDFILTEE
DF_1_DISPRELDNE
DF_1_DISPRELPND
DF_1_NODIRECT
DF_1_EDITED
DF_1_SYMINTPOSE
DF_1_GLOBAUDIT
DF_1_SINGLETON
DF_1_STUB
DF_1_PIE
DF_1_KMOD
DF_1_WEAKFILTER
@gopherbot gopherbot added this to the Proposal milestone Nov 21, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/452496 mentions this issue: debug/elf: add DT_FLAGS_1 constants

@ianlancetaylor ianlancetaylor moved this to Incoming in Proposals Nov 23, 2022
@ianlancetaylor
Copy link
Member

We generally permit new file format types and constants to be added without a formal proposal, as long as they follow the existing docs.

@florinpapa
Copy link
Contributor Author

Thanks, that's good to know. I was following the instructions in https://go.dev/doc/contribute#testing, and all.bash was complaining because of the api check.

@rsc rsc moved this from Incoming to Accepted in Proposals Feb 1, 2023
@rsc
Copy link
Contributor

rsc commented Feb 1, 2023

No change in consensus, so accepted. 🎉
This issue now tracks the work of implementing the proposal.
— rsc for the proposal review group

@rsc rsc changed the title proposal: debug/elf: add DT_FLAGS_1 (dynamic flags) constants debug/elf: add DT_FLAGS_1 (dynamic flags) constants Feb 1, 2023
@rsc rsc modified the milestones: Proposal, Backlog Feb 1, 2023
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Feb 1, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Go Compiler / Runtime Feb 3, 2023
johanbrandhorst pushed a commit to Pryz/go that referenced this issue Feb 12, 2023
@florinpapa @johanbrandhorst
debug/elf: add DT_FLAGS_1 constants
52197ed 
Add constants for all ELF dynamic flags (pertaining to DT_FLAGS_1). This will help, for example, determining whether an object is a position-independent executable (PIE). The constants are defined according to Table 15-10 in https://docs.oracle.com/en/operating-systems/solaris/oracle-solaris/11.4/linkers-libraries/dynamic-section.html.

Fixes golang#56887

Change-Id: I6cd501af50d9dbcc2aa8a9a002e12c6fb6726761
Reviewed-on: https://go-review.googlesource.com/c/go/+/452496
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/499616 mentions this issue: doc/go1.21: mention debug/elf changes

gopherbot pushed a commit that referenced this issue May 31, 2023
@ianlancetaylor @gopherbot
doc/go1.21: mention debug/elf changes
481665e 
For #55107
For #56887
For #56892

Change-Id: Ibcca34c931ed3595d877c4573bba221dec66bb5a
Reviewed-on: https://go-review.googlesource.com/c/go/+/499616
Reviewed-by: Eli Bendersky <eliben@google.com>
TryBot-Bypass: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
@mknyszek mknyszek mentioned this issue Jun 1, 2023
Closed
@dmitshur dmitshur modified the milestones: Backlog, Go1.21 Jun 4, 2023
@rsc rsc removed this from Proposals Feb 8, 2024
@golang golang locked and limited conversation to collaborators Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@florinpapa florinpapa

Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge help wanted Proposal Proposal-Accepted
Projects
None yet
Milestone
Go1.21
Development

No branches or pull requests
6 participants
@rsc @dmitshur @dr2chase @florinpapa @ianlancetaylor @gopherbot