-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: audit for Go 1.21 #60560
Comments
In #56984 it seems to me that the final accepted proposal was for func (x *Int) Float64() (float64, Accuracy) but what was actually implemented was func (x *Int) ToFloat64() (float64, Accuracy) I don't see any mention of CC @alandonovan |
@jba When you have time, can you verify that all the log/slog and testing/slogtest exported names are the desired ones? Thanks. |
@neild When you have time, can you verify that the various QUIC exported names in crypto/tls are the desired ones? Thanks. |
I want to call out that the crypto/x509 API implemented for #53753 is not the API that the proposal explicitly accepted and doesn't seem to be mentioned in the proposal issue itself. I don't see any real problem here but I would like somebody to double check this. Thanks. CC @golang/security @rolandshoemaker @aarongable |
Change https://go.dev/cl/500116 mentions this issue: |
I think the naming discussion happened before the proposal was accepted, and the finalized API is listed in a subsequent comment (which I now notice was in fact made after the proposal was accepted itself), but the parent comment was never updated to reflect this. I believe the naming in the follow-up (and what is the CL) is the better version of the proposed API, so while there is a minor mismatch in what was technically accepted and what was implemented, I think we ended up with what we actually want. |
@rolandshoemaker Great, thanks. |
The "To" prefix was a relic of the first draft that I failed to make consistent with the unprefixed name used in the proposal. Fortunately iant spotted it during the API audit. Updates #56984 Updates #60560 Change-Id: Ifa6eeddf6dd5f0637c0568e383f9a4bef88b10f9 Reviewed-on: https://go-review.googlesource.com/c/go/+/500116 Reviewed-by: Ian Lance Taylor <iant@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Alan Donovan <adonovan@google.com>
What @rolandshoemaker said, with my apologies for creating more work for y'all. |
Nitpicking: seems proposed and implemented was |
@andig Thanks for the note. |
@ianlancetaylor I've verified the slog symbols. At 5s/click, it will take me a while to check all the boxes. Is that necessary, or will this comment do? |
@jba I got you. For future reference, the checkbox state is changeable in the markdown. I just copied it into a text editor and did it from there. (EDIT: Annoying for sure, but at least there's some workaround! :P) |
Thanks, @mknyszek! |
Thanks. |
@FiloSottile I see one difference between the crypto/tls changes that were committed and the API described at #60105: the committed code has a |
The |
@neild Thanks, totally missed that. |
All APIs are now audited, so closing. |
This is a tracking issue for doing an audit of API additions for Go 1.21 as of https://go.dev/cl/499981.
New API changes for Go 1.21
bytes
cmp
context
crypto/elliptic
crypto/rsa
crypto/tls
crypto/x509
debug/elf
encoding/binary
errors
flag
go/ast
go/build/constraint
go/build
go/token
html/template
io/fs
log/slog
maps
math/big
net/http
net
reflect
regexp
runtime
slices
strings
sync
syscall
testing
testing/slogtest
unicode
The text was updated successfully, but these errors were encountered: