Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc/go1.14: document that unparsable URL in net/url.Error is now quoted #37661

Closed
wants to merge 4 commits into from
Closed

doc/go1.14: document that unparsable URL in net/url.Error is now quoted #37661

wants to merge 4 commits into from

Conversation

stefanb
Copy link
Contributor

@stefanb stefanb commented Mar 4, 2020 •
edited
Loading

Fixes #37614
Updates #36878
Updates #29384
Updates #37630

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Mar 4, 2020
@gopherbot
Copy link
Contributor

This PR (HEAD: 3ed9769) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/222037 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 9f87b7c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/222037 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/222037.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/222037.
After addressing review feedback, remember to publish your drafts!

@stefanb stefanb changed the title doc/go1.14: document that unparsable URL in net/url/Error is now quoted doc/go1.14: document that unparsable URL in net/url.Error is now quoted Mar 5, 2020
@gopherbot
Copy link
Contributor

This PR (HEAD: 0e6b2cd) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/222037 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Štefan Baebler:

Patch Set 3:

(3 comments)

Thanks for the suggestions,
I applied them all ;-)

Please don’t reply on this GitHub thread. Visit golang.org/cl/222037.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/222037.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 5297df3) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/222037 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Štefan Baebler:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/222037.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Štefan Baebler:

Patch Set 4:

(1 comment)

Thanks for the suggestion

Please don’t reply on this GitHub thread. Visit golang.org/cl/222037.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 5: Code-Review+2

Thanks!

Please don’t reply on this GitHub thread. Visit golang.org/cl/222037.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Mar 6, 2020
@stefanb @ianlancetaylor
doc/go1.14: document that unparsable URL in net/url.Error is now quoted
2b0f481 
Fixes #37614
Updates #36878
Updates #29384
Updates #37630

Change-Id: I63dad8b554353197ae0f29fa2a84f17bffa58557
GitHub-Last-Rev: 5297df3
GitHub-Pull-Request: #37661
Reviewed-on: https://go-review.googlesource.com/c/go/+/222037
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=4cfe835f

Please don’t reply on this GitHub thread. Visit golang.org/cl/222317.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Build is still in progress...
This change failed on android-amd64-emu:
See https://storage.googleapis.com/go-build-log/4cfe835f/android-amd64-emu_9ad778c6.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/222317.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1: TryBot-Result-1

1 of 19 TryBots failed:
Failed on android-amd64-emu: https://storage.googleapis.com/go-build-log/4cfe835f/android-amd64-emu_9ad778c6.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/222317.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 1: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/222317.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Mar 6, 2020
@stefanb @ianlancetaylor
[release-branch.go1.14] doc/go1.14: document that unparsable URL in n…
0e9f7ac 
…et/url.Error is now quoted

Updates #37614
Updates #36878
Updates #29384
Fixes #37630

Change-Id: I63dad8b554353197ae0f29fa2a84f17bffa58557
GitHub-Last-Rev: 5297df3
GitHub-Pull-Request: #37661
Reviewed-on: https://go-review.googlesource.com/c/go/+/222037
Reviewed-by: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit 2b0f481)
Reviewed-on: https://go-review.googlesource.com/c/go/+/222317
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/222317 has been merged.

@gopherbot gopherbot closed this Mar 6, 2020
@stefanb stefanb deleted the 114-release-notes-url-parsing-error-quoted branch June 7, 2021 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc: missing documentation of quoting the URL of url.Errors in go1.14 release notes
3 participants
@stefanb @gopherbot @googlebot