Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peplink OAuth #352

Closed
undeadindustries opened this issue Dec 18, 2018 · 1 comment
Closed

Peplink OAuth #352

undeadindustries opened this issue Dec 18, 2018 · 1 comment

Comments

@undeadindustries
Copy link

Please add the below token URL to brokenAuthHeaderProviders in token.go
https://api.ic.peplink.com/api/oauth2/token
@bradfitz
Copy link
Contributor

For now, use:
https://godoc.org/golang.org/x/oauth2#RegisterBrokenAuthHeaderProvider

But also, I'm working on killing it and making this all automatic in #111 and CL:
https://go-review.googlesource.com/c/oauth2/+/157820

So I'll close this for now.

gopherbot pushed a commit that referenced this issue Feb 11, 2019
@bradfitz
oauth2: auto-detect auth style by default, add Endpoint.AuthStyle
80673b4 
Instead of maintaining a global map of which OAuth2 servers do which
auth style and/or requiring the user to tell us, just try both ways
and remember which way worked. But if users want to tell us in the
Endpoint, this CL also add Endpoint.AuthStyle.

Fixes #111
Fixes #365
Fixes #362
Fixes #357
Fixes #353
Fixes #345
Fixes #326
Fixes #352
Fixes #268
Fixes https://go-review.googlesource.com/c/oauth2/+/58510
(... and surely many more ...)

Change-Id: I7b4d98ba1900ee2d3e11e629316b0bf867f7d237
Reviewed-on: https://go-review.googlesource.com/c/157820
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ross Light <light@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bradfitz @undeadindustries