-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
txtar: use slices.Clone instead of copy #523
txtar: use slices.Clone instead of copy #523
Conversation
This PR (HEAD: 0441413) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/613835. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/613835. |
Message from Michael Matloob: Patch Set 3: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/613835. |
Message from Michael Matloob: Patch Set 3: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/613835. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-09-17T14:30:46Z","revision":"d0ec739775136e297f02e67731cec6d798c150a5"} Please don’t reply on this GitHub thread. Visit golang.org/cl/613835. |
Message from Michael Matloob: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/613835. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/613835. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/613835. |
Message from Michael Matloob: Patch Set 3: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/613835. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-09-17T14:53:03Z","revision":"d0ec739775136e297f02e67731cec6d798c150a5"} Please don’t reply on this GitHub thread. Visit golang.org/cl/613835. |
Message from Michael Matloob: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/613835. |
This PR (HEAD: 468e405) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/613835. Important tips:
|
Message from Stavros Panakakis: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/613835. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/613835. |
Message from Michael Matloob: Patch Set 4: Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/613835. |
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-09-17T15:14:37Z","revision":"caf8b5806ed179fa7e8e12d765763337bbd792b9"} Please don’t reply on this GitHub thread. Visit golang.org/cl/613835. |
Message from Sam Thanawalla: Patch Set 4: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/613835. |
Message from Michael Matloob: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/613835. |
Message from Go LUCI: Patch Set 4: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/613835. |
Message from Go LUCI: Patch Set 4: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/613835. |
Message from Tim King: Patch Set 4: Auto-Submit+1 Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/613835. |
Message from Tim King: Patch Set 4: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/613835. |
Message from Stavros Panakakis: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/613835. |
Message from Tim King: Patch Set 5: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/613835. |
Use slices.Clone instead of copy now that x/tools uses Go >= 1.22. Resolves an outstanding TODO. Change-Id: Ia87f18e5e51f35dda5056538b9d0d0699c514ffc GitHub-Last-Rev: 468e405 GitHub-Pull-Request: #523 Reviewed-on: https://go-review.googlesource.com/c/tools/+/613835 Reviewed-by: Michael Matloob <matloob@golang.org> Reviewed-by: Sam Thanawalla <samthanawalla@google.com> Reviewed-by: Tim King <taking@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This PR is being closed because golang.org/cl/613835 has been merged. |
Use slices.Clone instead of copy now that x/tools uses Go >= 1.22.
Resolves an outstanding TODO.