Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/integration: Installation Tests are flaky #169

Closed
hyangah opened this issue Jun 3, 2020 · 3 comments
Closed

test/integration: Installation Tests are flaky #169

hyangah opened this issue Jun 3, 2020 · 3 comments
Labels
chore/testing issues related to bugs in test, CI setup FrozenDueToAge

Comments

@hyangah
Copy link
Contributor

hyangah commented Jun 3, 2020

1 failing

  1. Installation Tests
    install tools:
    Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/travis/gopath/src/github.com/hyangah/vscode-go/out/test/integration/install.test.js)
    at listOnTimeout (internal/timers.js:531:17)
    at processTimers (internal/timers.js:475:7)
    Error: 1 tests failed.
    Error: 1 tests failed.

https://travis-ci.org/github/hyangah/vscode-go/jobs/694401146
@hyangah hyangah added the chore/testing issues related to bugs in test, CI setup label Jun 3, 2020
@stamblerre
Copy link
Contributor

I wonder if the tests are just slow or actually failing. I think https://go-review.googlesource.com/c/vscode-go/+/236058 might be able to help with diagnosing that.

hyangah added a commit to hyangah/vscode-go-old that referenced this issue Jun 16, 2020
@hyangah
test: increase timeout and skip gopls update check in testing
f414011 
installation tests require multiple fs operations, and 2s may be
too short to complete everything on time. Allow more time.

And disable the gopls update check in gopls testing. That shortens
the time to bring up the gopls server.

Also remove the hack to start the test with a clean user profile
(--user-data-dir). That doesn't seem to work but interferes with
picking up the workspace settings, which I do not understand why.

Updates golang/vscode-go#169
Updates golang/vscode-go#43
Updates microsoft/vscode#97995

Change-Id: I5dbb33514a25a2071bf5bdf4ad248087e7e9b322
@hyangah hyangah mentioned this issue Jun 16, 2020
Closed
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/238001 mentions this issue: test: increase timeout and skip gopls update check in testing

gopherbot pushed a commit that referenced this issue Jun 16, 2020
@hyangah
test: increase timeout and skip gopls update check in testing
51b6e00 
installation tests require multiple fs operations, and 2s may be
too short to complete everything on time. Allow more time.

And disable the gopls update check in gopls testing. That shortens
the time to bring up the gopls server.

Also remove the hack to start the test with a clean user profile
(--user-data-dir). That doesn't seem to work but interferes with
picking up the workspace settings, which I do not understand why.

Updates #169
Updates #43
Updates microsoft/vscode#97995

Change-Id: I0e8b7d8f1f47f2e68696c6bd078c1ad2a0fe6780
GitHub-Last-Rev: f414011
GitHub-Pull-Request: #231
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/238001
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
@hyangah
Copy link
Contributor Author

hyangah commented Aug 7, 2020

I don't see any flakiness from this test. Closing.

@hyangah hyangah closed this as completed Aug 7, 2020
@golang golang locked and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
chore/testing issues related to bugs in test, CI setup FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hyangah @stamblerre @gopherbot