test: increase timeout and skip gopls update check in testing #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
installation tests require multiple fs operations, and 2s may be too short to complete everything on time. Allow more time. And disable the gopls update check in gopls testing. That shortens the time to bring up the gopls server. Also remove the hack to start the test with a clean user profile (--user-data-dir). That doesn't seem to work but interferes with picking up the workspace settings, which I do not understand why. Updates golang/vscode-go#169 Updates golang/vscode-go#43 Updates microsoft/vscode#97995 Change-Id: I5dbb33514a25a2071bf5bdf4ad248087e7e9b322
googlebot
added
the
cla: yes
|
This PR (HEAD: f414011) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/238001 to see it. Tip: You can toggle comments from me using the |
|
Message from Rebecca Stambler: Patch Set 1: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/238001. |
gopherbot
pushed a commit
that referenced
this pull request
Jun 16, 2020
installation tests require multiple fs operations, and 2s may be too short to complete everything on time. Allow more time. And disable the gopls update check in gopls testing. That shortens the time to bring up the gopls server. Also remove the hack to start the test with a clean user profile (--user-data-dir). That doesn't seem to work but interferes with picking up the workspace settings, which I do not understand why. Updates #169 Updates #43 Updates microsoft/vscode#97995 Change-Id: I0e8b7d8f1f47f2e68696c6bd078c1ad2a0fe6780 GitHub-Last-Rev: f414011 GitHub-Pull-Request: #231 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/238001 Reviewed-by: Rebecca Stambler <rstambler@golang.org>
|
This PR is being closed because golang.org/cl/238001 has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
installation tests require multiple fs operations, and 2s may be
too short to complete everything on time. Allow more time.
And disable the gopls update check in gopls testing. That shortens
the time to bring up the gopls server.
Also remove the hack to start the test with a clean user profile
(--user-data-dir). That doesn't seem to work but interferes with
picking up the workspace settings, which I do not understand why.
Updates #169
Updates #43
Updates microsoft/vscode#97995