Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

performance: consider bundling extension #53

Closed
hyangah opened this issue May 15, 2020 · 5 comments
Closed

performance: consider bundling extension #53

hyangah opened this issue May 15, 2020 · 5 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
v0.16.0

Comments

@hyangah
Copy link
Contributor

hyangah commented May 15, 2020

Original bug report is microsoft/vscode-go#2997

This extension got bigger. vsce recommends https://aka.ms/vscode-bundle-extension

This extension consists of 2266 files, out of which 1509 are JavaScript files. 
For performance reasons, you should bundle your extension: 
https://aka.ms/vscode-bundle-extension . You should also exclude unnecessary 
files by adding them to your .vscodeignore: https://aka.ms/vscode-vscodeignore

microsoft/vscode-extension-telemetry#41
(due to microsoft/ApplicationInsights-node.js-native-metrics#4) was one of the road blockers. We can probably prune the dependency.

Not sure about interaction with debug adapter yet.
@hyangah hyangah added the NeedsFix The path to resolution is known, but the work has not been done. label May 18, 2020
hyangah added a commit to hyangah/vscode-go-old that referenced this issue May 19, 2020
@hyangah
src/telemetry.ts: remove telemetry
28e31e2 
The existing telemetry code is no longer used.
Remove the dependency on the telemetry module
that was a blocker of extension bundling.

Update golang/vscode-go#53

Change-Id: I659166d121da05766cd5fd7ed16bbaf36e05c74b
@hyangah hyangah mentioned this issue May 19, 2020
Closed
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/234530 mentions this issue: src/telemetry.ts: remove telemetry

hyangah added a commit to hyangah/vscode-go-old that referenced this issue May 19, 2020
@hyangah
src/telemetry.ts: remove telemetry
3fefc68 
The existing telemetry code is no longer used.
Remove the dependency on the telemetry module
that was a blocker of extension bundling.

Update golang/vscode-go#53

Change-Id: I659166d121da05766cd5fd7ed16bbaf36e05c74b
hyangah added a commit to hyangah/vscode-go-old that referenced this issue May 20, 2020
@hyangah
src/telemetry.ts: remove telemetry
f0db5ab 
The existing telemetry code is no longer used.
Remove the dependency on the telemetry module
that was a blocker of extension bundling.

Update golang/vscode-go#53

Change-Id: I659166d121da05766cd5fd7ed16bbaf36e05c74b
gopherbot pushed a commit that referenced this issue May 20, 2020
@hyangah
src/telemetry.ts: remove telemetry
3a1715c 
The existing telemetry code is no longer used.
Remove the dependency on the telemetry module
that was a blocker of extension bundling.

Updates #53

Change-Id: I659166d121da05766cd5fd7ed16bbaf36e05c74b

Change-Id: I659166d121da05766cd5fd7ed16bbaf36e05c74b
GitHub-Last-Rev: f0db5ab
GitHub-Pull-Request: #74
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/234530
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
hyangah added a commit to hyangah/vscode-go-old that referenced this issue May 20, 2020
@hyangah
use webpack for packaging
64a8ec4 
WIP

Following the instruction in https://aka.ms/vscode-bundle-extension.

I couldn't turn on the 'production' mode yet in packaging due to
an issue with the Go Debug Adapter host program. Will keep investigating.

Updates golang/vscode-go#53

Change-Id: I3466188557038772966a351f9cd41754d8b5ffe4
hyangah added a commit to hyangah/vscode-go-old that referenced this issue May 20, 2020
@hyangah
use webpack for packaging
acc38cc 
WIP

Following the instruction in https://aka.ms/vscode-bundle-extension.

I couldn't turn on the 'production' mode yet in packaging due to
an issue with the Go Debug Adapter host program. Will keep investigating.

Updates golang/vscode-go#53

Change-Id: I3466188557038772966a351f9cd41754d8b5ffe4
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/236741 mentions this issue: [release] src/telemetry.ts: remove telemetry

gopherbot pushed a commit that referenced this issue Jun 5, 2020
@hyangah
[release] src/telemetry.ts: remove telemetry
1c67f6e 
The existing telemetry code is no longer used.
Remove the dependency on the telemetry module
that was a blocker of extension bundling.

Updates #53

Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/234530
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
(cherry picked from commit 3a1715c)

Change-Id: Ie65744a10796ca048c716c9d683eb0bfe390174c
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/236741
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
@hyangah hyangah mentioned this issue Jun 8, 2020
Closed
@OneOfOne
Copy link
Contributor

OneOfOne commented Jul 2, 2020

Is anyone working on this? if not I'd like to take work on it.

@hyangah
Copy link
Contributor Author

hyangah commented Jul 2, 2020

@OneOfOne i don't know anyone working on this. Last time I attempted, I was stuck at testing. Contribution is welcome!

@OneOfOne OneOfOne mentioned this issue Jul 6, 2020
Closed
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/241041 mentions this issue: webpack: bundle the extension

@hyangah hyangah added this to the v0.16.0 milestone Jul 7, 2020
This was referenced Jul 8, 2020
Closed
Closed
@golang golang locked and limited conversation to collaborators Jul 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging a pull request may close this issue.

webpack: bundle the extension
3 participants
@OneOfOne @hyangah @gopherbot