webpack: bundle the extension #286
Conversation
googlebot
added
the
cla: yes
Also update json-rpc2 which fixes 3/5 audit warnings.
|
This PR (HEAD: a242a28) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/241041 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: 106b801) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/241041 to see it. Tip: You can toggle comments from me using the |
|
Message from Hyang-Ah Hana Kim: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/241041. |
|
This PR (HEAD: 148d03f) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/241041 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: 6bacd00) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/241041 to see it. Tip: You can toggle comments from me using the |
|
Message from Ahmed W.: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/241041. |
|
This PR (HEAD: 0efae57) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/241041 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: e5f2ab1) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/241041 to see it. Tip: You can toggle comments from me using the |
|
Message from Ahmed W.: Patch Set 6: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/241041. |
|
This PR (HEAD: d7a9c4a) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/241041 to see it. Tip: You can toggle comments from me using the |
|
Message from Hyang-Ah Hana Kim: Patch Set 7: (10 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/241041. |
OneOfOne
changed the title
|
This PR (HEAD: 44ce961) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/241041 to see it. Tip: You can toggle comments from me using the |
|
Message from Ahmed W.: Patch Set 9: (10 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/241041. |
|
@hyangah did you get a chance to check the updates? after all those years, gerrit still confuses the crap out of me. |
|
Message from Hyang-Ah Hana Kim: Patch Set 9: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/241041. |
|
This PR (HEAD: c77c458) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/241041 to see it. Tip: You can toggle comments from me using the |
|
Message from Ahmed W.: Patch Set 10: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/241041. |
|
Message from Hyang-Ah Hana Kim: Patch Set 10: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/241041. |
|
Message from Ahmed W.: Patch Set 10: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/241041. |
This PR allows the extension to be bundled. Fixes #53 Change-Id: I0b9ac399c485f04fd7ddae885c277093f9931e34 GitHub-Last-Rev: c77c458 GitHub-Pull-Request: #286 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/241041 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
|
Message from Hyang-Ah Hana Kim: Patch Set 10: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/241041. |
|
This PR is being closed because golang.org/cl/241041 has been merged. |
|
It seems like this commit is related to my being unable to launch the extension now in a Extension Development Host, it complains about being unable to find "dist/goMain.js" |
|
https://go-review.googlesource.com/c/vscode-go/+/241861 And, in the mean time, run |
This PR allows the extension to be bundled.
Fixes #53