Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed to build golangci-lint v1.17.1 when enable GO111MODULE #581

Closed
liubog2008 opened this issue Jun 19, 2019 · 3 comments · Fixed by #605
Closed

Failed to build golangci-lint v1.17.1 when enable GO111MODULE #581

liubog2008 opened this issue Jun 19, 2019 · 3 comments · Fixed by #605

Comments

@liubog2008
Copy link 

$ go build -v ./...
build github.com/golangci/golangci-lint/cmd/golangci-lint: cannot load github.com/go-critic/go-critic/checkers: zip for github.com/go-critic/go-critic@v0.0.0-20181204210945-1df300866540 has unexpected file github.com/go-critic/go-critic@v0.0.0-20190526074819-1df300866540/.gitignore

go version: go1.12.5 linux/amd64
golangci-lint version: v1.17.1
@liubog2008 liubog2008 mentioned this issue Jun 19, 2019
Closed
@fhs
Copy link

fhs commented Jun 26, 2019

Go 1.13 gives a slightly better error:

$ GOPROXY=direct go get github.com/golangci/golangci-lint@latest
go get: github.com/golangci/golangci-lint@v1.17.1 requires
	github.com/go-critic/go-critic@v0.0.0-20181204210945-1df300866540: invalid pseudo-version: does not match version-control timestamp (2019-05-26T07:48:19Z)

@y3llowcake y3llowcake mentioned this issue Jul 3, 2019
Closed
This was referenced Jul 10, 2019
Merged
Closed
@pierrre
Copy link
Contributor

pierrre commented Jul 11, 2019

I've submitted a PR that fixes the issue
#605

@liubog2008
Copy link
Author

I have fixed it long long time ago = = @pierrre See #583

@bcmills bcmills mentioned this issue Jul 25, 2019
Closed
jirfag pushed a commit that referenced this issue Sep 9, 2019
@pierrre @jirfag
fix invalid dependencies (#605)
cdeefb5 
Some dependencies have invalid date.

Fixes #581 #595
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix invalid dependencies
3 participants
@pierrre @fhs @liubog2008