fix invalid dependencies #605

pierrre · 2019-07-10T10:07:20Z

Some dependencies have invalid date.

Fixes #581 #595

CLAassistant · 2019-07-10T10:07:24Z

All committers have signed the CLA.

pierrre · 2019-07-10T10:07:59Z

I don't know why some vendors have been deleted.

pierrre · 2019-07-10T12:15:37Z

Strangely, the vendored dependencies are not the same if I'm using Go 1.13beta or 1.12.x.
Now they're added correctly.

pierrre · 2019-07-15T14:07:06Z

Is someone available to review this PR ?

ww-daniel-mora · 2019-07-16T22:10:10Z

I am also experiencing this issue

Helcaraxan · 2019-07-18T17:01:54Z

Yes would be great if this could indeed be merged and a 1.17.2 patch release tagged (which would also contain the fix for #612 (i.e. #594).

FWIW. There are 2 other PRs (#583, #614) that address the same issue but I think this is the one that should be merged given it's the only one that actually updates go-critic and only go-critic to a recent commit.

dajohi

With this PR, i now get

$ env GOPROXY=direct GO111MODULE=on go build
go: github.com/golangci/errcheck@v0.0.0-20181003203344-ef45e06d44b6: invalid pseudo-version: does not match version-control timestamp (2018-12-23T08:41:20Z)

pierrre · 2019-07-23T16:18:42Z

@dajohi which version of Go are you using ?
I'm using 1.13beta1, and it was working fine.
Can someone else confirm ?

bcmills · 2019-07-25T19:14:57Z

@pierrre, the version check is performed when downloading the module from version control. If an invalid version is already present in your module cache, it will continue to be available to builds using that cache.

To test this change, you'll probably want to start from a clean module cache (either run go clean -modcache first or set GOPATH=$(mktemp -d)) and set GOPROXY=direct.

pierrre · 2019-07-26T08:07:51Z

Hi, sorry for the delay.
It should be fixed now.

Some dependencies have invalid date. Fixes #581 #595

pierrre · 2019-07-26T08:16:16Z

The build doesn't pass, but I don't understand the error.
Can someone help me ?

pierrre · 2019-07-26T08:18:57Z

It seems that docs/demo.svg is generated differently.
But it's not related to my PR.
I guess that master is also broken 🤷‍♂️

Helcaraxan · 2019-07-26T08:33:33Z

~~Just checking: did you run go run scripts/gen_readme/main.go?~~ I've just run it on master and there does not seem to be a diff which would imply it is not broken.

EDIT: also ran it on your branch and no diff.

CI seems to agree with me as well.

pierrre · 2019-07-26T08:36:17Z

➜  golangci-lint git:(bug/fix-581) go run scripts/gen_readme/main.go
2019/07/26 10:35:10 Successfully generated README.md
➜  golangci-lint git:(bug/fix-581) git --no-pager diff

there is no diff on my computer

Helcaraxan · 2019-07-26T08:37:30Z

Yes. Apologies. Edited my message above as well after I tested your branch myself. 👍

Having a look if I can figure out what's going on.

Helcaraxan · 2019-07-26T08:43:52Z

Ah got it, although not the root cause. You can regenerate the file locally by running:

make -B docs/demo.svg

The -B forces to regenerate the thing despite make thinking it's up-to-date. And it actually generates a diff.

My guess: given this relies on npm black magic I suppose some thing got updated somewhere and induced this hidden change. The npm environment is not checked / understood by make and thus is not picked-up as "changed".

pierrre · 2019-07-26T08:45:28Z

I'm sorry, but my PR is only about broken Go modules dependencies.
It wouldn't be correct to submit a change related to docs/demo.svg.

Helcaraxan · 2019-07-26T08:46:25Z

I'll have a look if I can make a sensible PR to fix it separately. 👍

Helcaraxan · 2019-07-26T09:14:43Z

@pierrre (and maintainers) proposed fix is up in PR #625. Once that one is merged we can rebase this PR on top of master and the CI should pass.

dahu33 · 2019-08-28T09:48:03Z

Any update from maintainer?

Helcaraxan · 2019-08-28T09:51:55Z

No. The maintainer has been inactive for 6 weeks now and there's no news available at the moment.

See #647.

bmhatfield · 2019-09-05T13:25:56Z

go.mod

@@ -1,11 +1,13 @@
 module github.com/golangci/golangci-lint

+go 1.11


Why does this PR specify go 1.11? I actively don't want this.

Could you explain what issue this raises for you?

This statement is not a hard requirement. It's merely an indication used by the go toolchain and you should not need to worry about it.

Tl;dr: This tells the Go compiler that if the build fails and you are using a < 1.11 version it will tell you it might be due to a too old Go version... however given that versions < 1.11 are not module aware they will not even bother / know how to interpret this.

For reference see the Go 1.12 release notes.

My understanding is that this specifier causes the files in the module to be built with an older version of Go?

As mentioned here: https://golang.org/doc/go1.12#modules

The go directive in a go.mod file now indicates the version of the language used by the files within that module.

It's actually a bit different.

the version of the language used by the files within that module

refers to the version for which the code was written (as it might be using a new function introduced in that version... but not necessarily), not the one with which the files should be built. As the sentence following the one you quote indicates:

If the go directive for a module specifies a version newer than the toolchain in use, the go command will attempt to build the packages regardless, and will note the mismatch only if that build fails.

I still feel that the writing is a bit ambiguous here, but I think I see what you're saying. I don't object if it's true that it's only a guideline. I just don't want tools like this to force-build on an old version, if that won't happen, I retract my objection :-)

You will always have full control over your build process. There is no version enforcement going, I can guarantee you that. 🙂

I'll forward the point about the feeling of ambiguity around the phrasing. I can imagine myself in your place and understand it can introduce confusion for people not familiar with the relatively new syntax of go.mod files.

jirfag · 2019-09-09T14:23:24Z

Guys sorry for the slow response. @pierrre thank you for the fix. I've merged it.
Some CI flaps, I will fix them later.

pierrre · 2019-09-09T16:43:58Z

Thank you !

diovann · 2019-09-22T10:27:39Z

C:\Users\diovann>cd c:\go-work\HOME\core\

c:\go-work\HOME\core>go build
go: github.com/golangci/golangci-lint@v1.17.1 requires
github.com/go-critic/go-critic@v0.0.0-20181204210945-1df300866540: inval
id pseudo-version: does not match version-control timestamp (2019-05-26T07:48:19
Z)

c:\go-work\HOME\core>

how to fix this error??

Helcaraxan · 2019-09-22T10:40:49Z

@diovann you need to upgrade your dependency on golangci-lint to v1.18.0. That version contains the fix.

diovann · 2019-09-22T10:45:07Z

how to upgrade golangci-lint to v1.18.0 ??

Helcaraxan · 2019-09-22T10:49:22Z

It depends.

If you are simply trying to build golangci-lint, and supposing you have cloned it as a Git repository, in the same folder do git fetch && git checkout v0.18.0 followed by go build or go install.
If golangci-lint is a dependency of your own project then go get -u github.com/golangci/golangci-lint@v1.18.0 && go mod tidy should do it.

NB: If it's someone else's project you can still do 2. but you will need to raise a pull request against the project in question, or you need to file an issue with the project for the maintainers to upgrade their dependency.

diovann · 2019-09-22T14:05:02Z

@Helcaraxan thanks for this bro. !!

Helcaraxan mentioned this pull request Jul 18, 2019

update deps; fix go 1.13 #614

Closed

Helcaraxan mentioned this pull request Jul 18, 2019

fix go mod problem #583

Closed

dajohi reviewed Jul 19, 2019

View reviewed changes

fix invalid dependencies

c3a532e

Some dependencies have invalid date. Fixes #581 #595

Helcaraxan mentioned this pull request Jul 26, 2019

Make generation of demo.svg deterministic #625

Merged

pierrre mentioned this pull request Aug 5, 2019

go.mod: fix timestamp on module replacement for bodyclose #629

Closed

DazWilkin mentioned this pull request Aug 6, 2019

golangci-lint dependency on go-critic issue w/ golang 1.13 (works w/ <=golang:1.12.7) google/trillian#1786

Closed

pmazzini mentioned this pull request Aug 7, 2019

Basic go module support. coredhcp/coredhcp#39

Merged

pierrre mentioned this pull request Aug 26, 2019

golangci-lint won't compile with Go modules on go 1.13 #652

Closed

pierrre mentioned this pull request Aug 28, 2019

cmd/go: allow get from PR commit golang/go#33908

Closed

Helcaraxan mentioned this pull request Aug 29, 2019

Status of the project #647

Closed

laverya mentioned this pull request Sep 4, 2019

fix the timestamp for golangci/bodyclose 65da19158fa2 #660

Closed

jrick mentioned this pull request Sep 4, 2019

Politeia cannot be built in Go 1.13 decred/politeia#991

Closed

bmhatfield reviewed Sep 5, 2019

View reviewed changes

Helcaraxan mentioned this pull request Sep 5, 2019

cmd/go: go directive is insufficiently documented for module authors to be able to make a decision about its value golang/go#30791

Closed

Merge branch 'master' into bug/fix-581

5294082

jirfag merged commit cdeefb5 into golangci:master Sep 9, 2019

pierrre mentioned this pull request Sep 9, 2019

Build errors using Go 1.13 #659

Closed

tpounds added the bug Something isn't working label Oct 5, 2019

ldez added this to the v1.18 milestone Mar 6, 2024

		@@ -1,11 +1,13 @@
		module github.com/golangci/golangci-lint

		go 1.11

fix invalid dependencies #605

fix invalid dependencies #605

Conversation

pierrre commented Jul 10, 2019

CLAassistant commented Jul 10, 2019 • edited Loading

pierrre commented Jul 10, 2019

pierrre commented Jul 10, 2019

pierrre commented Jul 15, 2019

ww-daniel-mora commented Jul 16, 2019

Helcaraxan commented Jul 18, 2019

dajohi left a comment • edited Loading

Choose a reason for hiding this comment

pierrre commented Jul 23, 2019

bcmills commented Jul 25, 2019

pierrre commented Jul 26, 2019

pierrre commented Jul 26, 2019

pierrre commented Jul 26, 2019

Helcaraxan commented Jul 26, 2019 • edited Loading

pierrre commented Jul 26, 2019

Helcaraxan commented Jul 26, 2019

Helcaraxan commented Jul 26, 2019

pierrre commented Jul 26, 2019

Helcaraxan commented Jul 26, 2019

Helcaraxan commented Jul 26, 2019

dahu33 commented Aug 28, 2019

Helcaraxan commented Aug 28, 2019

bmhatfield Sep 5, 2019

Choose a reason for hiding this comment

Helcaraxan Sep 5, 2019 • edited Loading

Choose a reason for hiding this comment

Helcaraxan Sep 5, 2019

Choose a reason for hiding this comment

bmhatfield Sep 5, 2019

Choose a reason for hiding this comment

Helcaraxan Sep 5, 2019

Choose a reason for hiding this comment

bmhatfield Sep 5, 2019

Choose a reason for hiding this comment

Helcaraxan Sep 5, 2019

Choose a reason for hiding this comment

jirfag commented Sep 9, 2019

pierrre commented Sep 9, 2019

diovann commented Sep 22, 2019

Helcaraxan commented Sep 22, 2019

diovann commented Sep 22, 2019

Helcaraxan commented Sep 22, 2019

diovann commented Sep 22, 2019

CLAassistant commented Jul 10, 2019 •

edited

Loading

dajohi left a comment •

edited

Loading

Helcaraxan commented Jul 26, 2019 •

edited

Loading

Helcaraxan Sep 5, 2019 •

edited

Loading