Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contextcheck: bump to v1.0.5 && add noCache flag #2525

Closed
wants to merge 1 commit into from

Conversation

sylvia7788
Copy link
Contributor

@sylvia7788 sylvia7788 commented Jan 27, 2022

The pkg that the current buildssa.SSA.Pkg depends on cannot be built because its info is nil.
https://github.com/golang/tools/blob/0f0bbfd77bf2de5c3a4bc5cc6126522f42ef47c7/go/analysis/passes/buildssa/buildssa.go#L55-L68
If you want to get a function with Block, you can only get it from the analysis results of the previous dependent packages, but the cache will cause the analysis of the dependent packages to be skipped, so nocache is added.
kkHAIKE/contextcheck@v1.0.4...v1.0.5

@ldez ldez self-requested a review January 27, 2022 08:19
@ldez ldez added the blocked Need's direct action from maintainer label Jan 27, 2022
@ldez
Copy link
Member

ldez commented Jan 28, 2022

The noCache option disables the cache for all the linters, so we cannot follow this way.
So you will have to find another solution/way.

Note: your implementation produces panic during the analysis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants