Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApplyLayer exit status 1 stdout: stderr: open /var/log/lastlog: no such file or directory #104

Closed
vrutkovs opened this issue Jul 8, 2016 · 3 comments
Closed

ApplyLayer exit status 1 stdout: stderr: open /var/log/lastlog: no such file or directory #104

vrutkovs opened this issue Jul 8, 2016 · 3 comments
Labels
type/bug
Milestone
1.0.0

Comments

@vrutkovs
Copy link
Contributor

vrutkovs commented Jul 8, 2016

Some files seem to be missing, as image cannot be loaded after squashing.

Full log
@goldmann
Copy link
Owner

I got the image offline, investigating.

@goldmann goldmann added this to the 1.0.0 milestone Jul 11, 2016
@goldmann
Copy link
Owner

Found the cause. Since we merge layers from the end (newest) we add a symlink (/var/log) to a non-existent location (/data/var/log). Later we try to add some files under the /var/log/ path. Tar will accept anything, but at the extraction time Docker will complain because it doesn't know where to extract it (there is no /data/var/log path).

goldmann added a commit that referenced this issue Jul 11, 2016
@goldmann
Better handling of symlinks pointing to non-existing locations
d568d17 
If we have a symlink to a location that does not exist in the
squashed tar (yet), we don't know if it's a file or a directory.
In case it's a directory - we cannot add any new files under
this directory because extration will fail at the import time.
Assume here the target is directory (if it's a file it won't
break) and skip all files that should be added under this directory.

Fixes #104.
@goldmann goldmann mentioned this issue Jul 11, 2016
Merged
@goldmann
Copy link
Owner

A proposed fix has been submitted as a PR #105.

goldmann added a commit that referenced this issue Jul 22, 2016
@goldmann
Merge pull request #105 from goldmann/gh-104-broken-symlinks
afd81ae 
Better handling of symlinks pointing to non-existing locations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@goldmann @vrutkovs