Better handling of symlinks pointing to non-existing locations #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we have a symlink to a location that does not exist in the squashed tar (yet), we don't know if it's a file or a directory. In case it's a directory - we cannot add any new files under this directory because extration will fail at the import time. Assume here the target is directory (if it's a file it won't break) and skip all files that should be added under this directory. Fixes #104.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have a symlink to a location that does not exist in the
squashed tar (yet), we don't know if it's a file or a directory.
In case it's a directory - we cannot add any new files under
this directory because extration will fail at the import time.
Assume here the target is directory (if it's a file it won't
break) and skip all files that should be added under this directory.
Fixes #104.