Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdout/stderr #144

Closed
brubbel opened this issue Mar 14, 2017 · 6 comments
Closed

stdout/stderr #144

brubbel opened this issue Mar 14, 2017 · 6 comments
Assignees
Labels
Milestone

Comments

@brubbel
Copy link

brubbel commented Mar 14, 2017

Hi, it seems that docker-squash is using the stderr stream to provide info messages.
However this breaks automated build systems, which rely on stderr to detect actual errors.
Is this intended behaviour?
Thanks for checking.

Name: docker-squash
Version: 1.0.5 (from pip)

@goldmann
Copy link
Owner

That is a surprising info. How do you execute it? Can you give me some output that is redirected to stderr?

@brubbel
Copy link
Author

brubbel commented Mar 14, 2017

docker-squash hello-world -t hello-world-squashed 2>/dev/null
In my version, docker-squash will run silent until finished.

@goldmann
Copy link
Owner

I can confirm this. I'll take a look, thanks!

@goldmann goldmann self-assigned this Mar 14, 2017
@goldmann
Copy link
Owner

It looks that the StreamHandler by default writes to stderr: https://docs.python.org/2/library/logging.handlers.html#logging.StreamHandler This is an easy fix.

@brubbel
Copy link
Author

brubbel commented Mar 14, 2017

If possible, can you also publish this fix to PyPI later on? Thanks for the fast solution!

@goldmann
Copy link
Owner

Yes, definitely. This will be part of 1.0.6 release. I do plan to add a few other issues to this release.

@goldmann goldmann added this to the 1.0.6 milestone Mar 14, 2017
goldmann added a commit that referenced this issue Mar 14, 2017
INFO goes to stdout, everything else goes to stderr

Fixes #144
goldmann added a commit that referenced this issue Mar 15, 2017
Send messages to appropriate streams
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants