Send messages to appropriate streams #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
INFO goes to stdout, everything else goes to stderr Fixes #144
|
@l-d-j Any opinions? |
|
I dont mind - but tbh i think any app should rely on exit code - not random stuff in err out :) |
|
@l-d-j Yes, I agree fully with you. Automated systems should use exit code or (if this is a Python tool) - use the squash tool directly, as a library. |
praiskup
added a commit
to praiskup/container-common-scripts
that referenced
this pull request
Nov 30, 2018
The docker-squash script used to print the squashed <image id> on stderr, but recently it was changed so the image id is printed to stdout. To be able to parse image id from both docker_squash versions (before and after this change), we'd have to have some ugly if-fork to detect the docker_squash version. So rather let's do as upstream suggested in [1] and use the docker_squash library directly. Also add a simple CI test for the ./squash.py file. [1] goldmann/docker-squash#145 Fixes: sclorg#101
praiskup
added a commit
to praiskup/container-common-scripts
that referenced
this pull request
Nov 30, 2018
The docker-squash script used to print the squashed <image id> on stderr, but recently it was changed so the image id is printed to stdout. To be able to parse image id from both docker_squash versions (before and after this change), we'd have to have some ugly if-fork to detect the docker_squash version. So rather let's do as upstream suggested in [1] and use the docker_squash library directly. Also add a simple CI test for the ./squash.py file. [1] goldmann/docker-squash#145 Fixes: sclorg#101
praiskup
added a commit
to praiskup/container-common-scripts
that referenced
this pull request
Nov 30, 2018
The docker-squash script used to print the squashed <image id> on stderr, but recently it was changed so the image id is printed to stdout. To be able to parse image id from both docker_squash versions (before and after this change), we'd have to have some ugly if-fork to detect the docker_squash version. So rather let's do as upstream suggested in [1] and use the docker_squash library directly. Also add a simple CI test for the ./squash.py file. [1] goldmann/docker-squash#145 Fixes: sclorg#101
praiskup
added a commit
to praiskup/container-common-scripts
that referenced
this pull request
Dec 4, 2018
The docker-squash script used to print the squashed <image id> on stderr, but recently it was changed so the image id is printed to stdout. To be able to parse image id from both docker_squash versions (before and after this change), we'd have to have some ugly if-fork to detect the docker_squash version. So rather let's do as upstream suggested in [1] and use the docker_squash library directly. Also add a simple CI test for the ./squash.py file. [1] goldmann/docker-squash#145 Fixes: sclorg#101
praiskup
added a commit
to praiskup/container-common-scripts
that referenced
this pull request
Dec 4, 2018
The docker-squash script used to print the squashed <image id> on stderr, but recently it was changed so the image id is printed to stdout. To be able to parse image id from both docker_squash versions (before and after this change), we'd have to have some ugly if-fork to detect the docker_squash version. So rather let's do as upstream suggested in [1] and use the docker_squash library directly. Also add a simple CI test for the ./squash.py file. [1] goldmann/docker-squash#145 Fixes: sclorg#101
praiskup
added a commit
to praiskup/container-common-scripts
that referenced
this pull request
Dec 5, 2018
The docker-squash script used to print the squashed <image id> on stderr, but recently it was changed so the image id is printed to stdout. To be able to parse image id from both docker_squash versions (before and after this change), we'd have to have some ugly if-fork to detect the docker_squash version (or play with FD redirection). So rather let's do as upstream suggested in [1] and use the docker_squash library directly. Also add a simple CI test for the ./squash.py file. [1] goldmann/docker-squash#145 Fixes: sclorg#101
praiskup
added a commit
to sclorg/container-common-scripts
that referenced
this pull request
Dec 5, 2018
The docker-squash script used to print the squashed <image id> on stderr, but recently it was changed so the image id is printed to stdout. To be able to parse image id from both docker_squash versions (before and after this change), we'd have to have some ugly if-fork to detect the docker_squash version (or play with FD redirection). So rather let's do as upstream suggested in [1] and use the docker_squash library directly. Also add a simple CI test for the ./squash.py file. [1] goldmann/docker-squash#145 Fixes: #101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INFO goes to stdout, everything else goes to stderr
Fixes #144