This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Update to Task API v0.16.1 #4707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wiezzel
force-pushed
the
task_api_envs
branch
2 times, most recently
from
1d86bdc
to
74e9669
Compare
Wiezzel
force-pushed
the
task_api_envs
branch
from
74e9669
to
0ebc4b0
Compare
Krigpl
reviewed
Sep 10, 2019
maaktweluit
approved these changes
Sep 11, 2019
There was a problem hiding this comment.
LGTM!
+1 for @Krigpl 's proposal about less repeating mocks
Codecov Report
@@ Coverage Diff @@
## develop #4707 +/- ##
===========================================
+ Coverage 90.23% 90.28% +0.04%
===========================================
Files 211 211
Lines 19677 19682 +5
===========================================
+ Hits 17756 17770 +14
+ Misses 1921 1912 -9 |
Wiezzel
force-pushed
the
task_api_envs
branch
2 times, most recently
from
d94eea3
to
950a4d6
Compare
Krigpl
approved these changes
Sep 12, 2019
* Import environment IDs from Task API instead of declaring them in Golem code. * Read the environment ID and prerequisites from CreateTask reply. Save the obtained values in RequestedTask model. Signed-off-by: Adam Wierzbicki <awierzbicki@golem.network>
Wiezzel
force-pushed
the
task_api_envs
branch
from
950a4d6
to
23a9786
Compare
maaktweluit
added a commit
that referenced
this pull request
Sep 13, 2019
maaktweluit
added a commit
that referenced
this pull request
Sep 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements will be updated when golemfactory/task-api#37 is merged and Task API v0.16.0 is released.