Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing computational environments to Task API #37

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Introducing computational environments to Task API #37

merged 1 commit into from
Sep 10, 2019

Conversation

Wiezzel
Copy link

@Wiezzel Wiezzel commented Sep 5, 2019

  • CreateTaskReply: env_id and prerequisites_json added
  • Constants for environment IDs
  • DockerPrerequisites schema
  • Utility functions for creating responses

@Wiezzel Wiezzel self-assigned this Sep 5, 2019
@Wiezzel
Copy link
Author

Wiezzel commented Sep 5, 2019

Not sure about the approach, let me know what you think.

Copy link
Contributor

@maaktweluit maaktweluit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One nitty comment, will still approve

python/golem_task_api/envs/__init__.py Outdated Show resolved Hide resolved
* CreateTaskReply: env_id and prerequisites_json added
* Constants for environment IDs
* DockerPrerequisites schema
* Utility functions for creating responses

Signed-off-by: Adam Wierzbicki <awierzbicki@golem.network>
@Wiezzel Wiezzel merged commit 31414ff into master Sep 10, 2019
@Wiezzel Wiezzel deleted the envs branch September 10, 2019 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants