This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
limit benchmark-based usage factors #4803
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmazurek
approved these changes
Oct 18, 2019
Codecov Report
@@ Coverage Diff @@
## develop #4803 +/- ##
===========================================
- Coverage 89.41% 89.35% -0.06%
===========================================
Files 226 216 -10
Lines 20529 20103 -426
===========================================
- Hits 18355 17964 -391
+ Misses 2174 2139 -35 |
shadeofblue
reviewed
Oct 22, 2019
| usage_factor = 1.0 | ||
|
|
||
| # Sanity check against misreported benchmarks | ||
| usage_factor = min(max(usage_factor, 0.25), 1.5) |
There was a problem hiding this comment.
why are we assuming that the usage cannot be farther away than that from our own? can't a really slow or really fast CPU have such - out of range - results?
There was a problem hiding this comment.
It can, but if it is, it will be caught by the usage factor adjustment. It may make sense to widen the limits though.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes usage benchmark results can get misreported. This PR introduces sanity checks for usage factors based on these benchmark results, limiting them to the [0.25,1.5] range.
Additionally, we prevent dividing by 0 (or other very small value of the usage benchmark).