This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Fix division and limit benchmark-based usage factors #4827
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes usage benchmark results can get misreported. This PR introduces sanity checks for usage factors based on these benchmark results, limiting them to the [0.1,2] range.
This PR also modifies initial usage factor calculation to take into account the fact that with usage benchmarks, (in contrast to efficiency benchmarks), faster machines correspond to smaller values.
Additionally, we prevent dividing by 0 (or other very small value of the usage benchmark).
Note: this PR is basically #4803 rebased to develop after merging #4802