Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Fix division and limit benchmark-based usage factors #4827

Merged
merged 4 commits into from
Oct 24, 2019

Conversation

mbenke
Copy link
Contributor

@mbenke mbenke commented Oct 24, 2019

Sometimes usage benchmark results can get misreported. This PR introduces sanity checks for usage factors based on these benchmark results, limiting them to the [0.1,2] range.

This PR also modifies initial usage factor calculation to take into account the fact that with usage benchmarks, (in contrast to efficiency benchmarks), faster machines correspond to smaller values.

Additionally, we prevent dividing by 0 (or other very small value of the usage benchmark).

Note: this PR is basically #4803 rebased to develop after merging #4802

Copy link
Contributor

@shadeofblue shadeofblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

darth-vader-thumbs-up

@codecov
Copy link

codecov bot commented Oct 24, 2019

Codecov Report

Merging #4827 into develop will increase coverage by 0.04%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #4827      +/-   ##
===========================================
+ Coverage     89.2%   89.24%   +0.04%     
===========================================
  Files          226      226              
  Lines        20775    20567     -208     
===========================================
- Hits         18532    18355     -177     
+ Misses        2243     2212      -31

@mbenke mbenke merged commit ae2be22 into develop Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants