Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ray - yagna & websocat as pip dependencies #139

Merged
merged 7 commits into from
Oct 31, 2023

Conversation

mateuszsrebrny
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Oct 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
golem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 11:06pm

Copy link
Contributor

@shadeofblue shadeofblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. question -> don't we want to mention websocat anywhere?

@mateuszsrebrny
Copy link
Contributor Author

lgtm. question -> don't we want to mention websocat anywhere?

do we?

In my eyes it doesn't differ much from all other libs that we use and is hidden with pip and yagna, I see no moment where a user would need to interact with websocat (as opposed to yagna)...

unless you for you it is somehow different?

@mateuszsrebrny mateuszsrebrny marked this pull request as ready for review October 31, 2023 12:33
@mateuszsrebrny
Copy link
Contributor Author

mateuszsrebrny commented Oct 31, 2023

@cryptobench ready for merge & deploy 🙏

@cryptobench cryptobench merged commit 56ea7fa into master Oct 31, 2023
3 checks passed
@mateuszsrebrny mateuszsrebrny deleted the mateusz/ray-yagna-n-websocat-as-pip-dependencies branch November 21, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants