This repository has been archived by the owner on Nov 3, 2022. It is now read-only.
Support ExecOptions in dockerman. #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
prekucki
suggested changes
Jul 19, 2019
gu-model/src/envman.rs
Outdated
| #[derive(Clone, Serialize, Deserialize, Hash, Eq, PartialEq, Debug)] | ||
| #[serde(rename_all = "camelCase")] | ||
| pub enum Command { | ||
| Exec { | ||
| // return cmd output | ||
| executable: String, | ||
| args: Vec<String>, | ||
| options: ExecOptions, |
There was a problem hiding this comment.
Change is not backward compatible. it breaks current applications. #[serde(default)] is minimal
prekucki
approved these changes
Jul 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's easier to add it as an extra field in
Command::Exec, but then usingsession.update(...)from gu-client gets a little more tedious (you need to manually provide the options for each command). An alternative is to add a method to the deployment API, but this will be tricky if we want to run several commands with different working directories (which may actually be the case for gumpi), so I have second thoughts about adding more global state.