-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for running inside Docker containers #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marmistrz
changed the title
Add support for running inside Docker containers
WIP: Add support for running inside Docker containers
Jul 10, 2019
The PR is basically ready, we're only waiting for the GU blockers. |
We'll probably need to have |
Move to tokio-ctrlc-error for ctrlc handling
marmistrz
changed the title
WIP: Add support for running inside Docker containers
Add support for running inside Docker containers
Aug 30, 2019
One of the indirect dependencies, flate2, no longer builds on 1.33
Because this PR was pending for a very long time, I'll merge this PR without a review as an exception. @kubkon, please take a look when you have a while, I'll address the issues (if any) in a subsequent PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change takes advantage of the Docker capabilities present in golem-unlimited. Closes #12. Closes #2. Closes #29.
Changes:
/app/
,/output/
,/input/
) and a default location for the output directory (/output
) has been addedTODO:
output
[needs-gu-changes]mpirun
[needs-gu-changes]mv_cmd
)mca btl
hack (nope)SYS_PTRACE
capabilityTODO-GU:
GU blockers:
Command::Exec
doesn't return proper errors in case the program execution fails under dockerman: No error return if Command::Exec execution fails in dockerman golem-unlimited#250Deferred issues: (follow-up issues will be created)
/dev/shm
, Docker limits it to 64M. Probably using--tmpfs /dev/shm
should be enough to guarantee unlimited/dev/shm