Fix Pyright error when creating modules #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeilGirdhar
force-pushed
the
fix_pright2
branch
from
0ea8cdc
to
4d1b5ef
Compare
superbobry
approved these changes
Sep 11, 2023
tomhennigan
approved these changes
Sep 12, 2023
superbobry
approved these changes
Sep 12, 2023
copybara-service
bot
merged commit 646e60f
into
google-deepmind:main
7 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, my mistake, it appears to still be broken. Pyright doesn't even accept any annotation here.