Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Pyright error when creating modules #716

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Fix Pyright error when creating modules #716

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d1b5ef
Fix Pyright error when creating modules
NeilGirdhar Aug 8, 2023
b139684
Merge branch 'google-deepmind:main' into fix_pright2
NeilGirdhar Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion haiku/_src/module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ def __new__( # pylint: disable=bad-classmethod-argument

return cls

def __call__(cls: "ModuleMetaclass", *args, **kwargs) -> Any: # pylint: disable=no-self-argument
def __call__(cls, *args, **kwargs) -> Any: # pylint: disable=no-self-argument
# Call new such that we have an un-initialized module instance that we can
# still reference even if there is an exception during __init__. This is
# needed such that we can make sure the name_scope constructed in __init__
Expand Down
Loading