Cleanup extension update logic by jakemac53 · Pull Request #10514 · google-gemini/gemini-cli

jakemac53 · 2025-10-03T22:06:39Z

TLDR

Avoids repeatedly checking for updates when we have already done so and leans into the reducer approach more heavily.

Dive deeper

Various cleanups to rely more heavily on the reducer, and handle all updates from within useExtensionUpdates - the slash command also just dispatches an event to the reducer now.

Also cleaned up the checkForExtensionUpdate function so it just returns an extension state instead of internally calling a function to update the state, this makes it more testable/portable outside of react.

checkForAllExtensionUpdates now also takes a current working directory, which fixes a potential bug in at least one place where we should have been flowing through the working dir from the context instead of using process.cwd().

This also paves the way for a future /extensions check command which can similarly just fire an event on a reducer.

We also have a centralized place handling all the update checks as well as actual updates, and this should help with any race conditions that may have existed before.

Testing Matrix

	🍏	🪟	🐧
npm run	❓	❓	❓
npx	❓	❓	❓
Docker	❓	❓	❓
Podman	❓	-	-
Seatbelt	❓	-	-

Linked issues / bugs

gemini-code-assist · 2025-10-03T22:07:00Z

Summary of Changes

Hello @jakemac53, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the extension update mechanism to enhance robustness, testability, and maintainability. By transitioning to a reducer-based approach for managing update states and scheduling, it centralizes the logic for checking and applying updates. This change also streamlines the API for individual update checks and ensures correct working directory context is consistently applied, paving the way for future command implementations.

Highlights

Refactored Extension Update Logic: The checkForExtensionUpdate function now directly returns an ExtensionUpdateState instead of using a callback, simplifying its usage and making it more testable.
Centralized Update Scheduling with Reducer: The useExtensionUpdates hook and the /extensions update command now leverage a reducer pattern to schedule and manage extension updates, avoiding repeated checks and centralizing state management.
Improved Working Directory Handling: The checkForAllExtensionUpdates function now explicitly accepts a cwd (current working directory) parameter, addressing a potential bug where process.cwd() was incorrectly used in some contexts.
Semantic Clarity in Update Status: The ExtensionUpdateStatus interface has been updated to use a notified flag instead of processed, providing clearer semantics for when an update has been communicated to the user.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request is a great refactoring that centralizes the extension update logic using a reducer pattern, which significantly improves maintainability and testability. The checkForExtensionUpdate function is now purer by returning a value directly, and the slash command has been simplified to just dispatch actions. Overall, these are excellent changes that align well with modern state management practices. I've identified one critical syntax issue that would lead to a crash and a related high-severity logical flaw in the new reducer logic for handling concurrent updates. My review comments provide details and suggestions for fixes.

packages/cli/src/ui/state/extensions.ts

github-actions · 2025-10-03T22:10:11Z

Size Change: +970 B (+0.01%)

Total Size: 17.6 MB

ℹ️ View Unchanged

Filename	Size	Change
`./bundle/gemini.js`	17.5 MB	+970 B (+0.01%)
`./bundle/sandbox-macos-permissive-closed.sb`	1.03 kB	0 B
`./bundle/sandbox-macos-permissive-open.sb`	830 B	0 B
`./bundle/sandbox-macos-permissive-proxied.sb`	1.31 kB	0 B
`./bundle/sandbox-macos-restrictive-closed.sb`	3.29 kB	0 B
`./bundle/sandbox-macos-restrictive-open.sb`	3.36 kB	0 B
`./bundle/sandbox-macos-restrictive-proxied.sb`	3.56 kB	0 B

_{compressed-size-action}

jakemac53 · 2025-10-03T22:11:12Z

packages/cli/src/ui/hooks/useExtensionUpdates.ts

+    );
+  }, [
+    extensions,
+    extensionsUpdateState.extensionStatuses,


Note that this is a new dependency - but it doesn't create a render loop even though we also call dispatchExtensionStateUdpate - because these states are linear.

This ensures we don't keep checking for updates to extensions that we have already checked or are currently checking.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

jacob314 · 2025-10-03T23:21:48Z

packages/cli/src/commands/extensions/update.ts

+          if (action.type === 'SET_STATE') {
+            extensionState.set(action.payload.name, {
+              status: action.payload.state,
+              notified: true, // No need to process as we will force the update.


update the comment to align with the code.
Optional nit: this is now a lie as we haven't notified.
to be overly pedantic we could label this
notificationRequested or something similar. Then it can be false here to exactly indicate the state.

I could also just remove this entirely, its not necessary in this code path, and this code path does not do any notifications of available updates, it always installs them.

I went ahead and just made that change, to just not indicate we notified. This code path is for the regular update command outside the CLI itself.

packages/cli/src/ui/state/extensions.ts

jacob314

Congrats on your first big reducer change! Approved once these comments are addressed.

jacob314

…#10514)

Co-authored-by: Jacob MacDonald <jakemac@google.com> Co-authored-by: Adam Weidman <65992621+adamfweidman@users.noreply.github.com>

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

jakemac53 added 3 commits October 3, 2025 20:48

Clean up extension logic and remove duplicate update notifications

05556c9

update the extensionsCommand test and refactor it a bit

79e7f4a

s/processed/notified in update.ts

3cda09a

jakemac53 requested a review from a team as a code owner October 3, 2025 22:06

jakemac53 requested a review from jacob314 October 3, 2025 22:06

use workingDir in update.ts

69d56b3

gemini-code-assist bot reviewed Oct 3, 2025

View reviewed changes

packages/cli/src/ui/state/extensions.ts Outdated Show resolved Hide resolved

packages/cli/src/ui/state/extensions.ts Show resolved Hide resolved

jakemac53 commented Oct 3, 2025

View reviewed changes

Apply suggestion from @gemini-code-assist[bot]

483d66e

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

jacob314 reviewed Oct 3, 2025

View reviewed changes

packages/cli/src/ui/state/extensions.ts Outdated Show resolved Hide resolved

jacob314 reviewed Oct 3, 2025

View reviewed changes

code review updates

2267d65

jakemac53 enabled auto-merge October 4, 2025 03:22

jacob314 approved these changes Oct 4, 2025

View reviewed changes

jakemac53 added this pull request to the merge queue Oct 4, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 4, 2025

jakemac53 added this pull request to the merge queue Oct 4, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 4, 2025

jakemac53 added this pull request to the merge queue Oct 4, 2025

Merged via the queue into main with commit 7f8537a Oct 4, 2025
20 checks passed

jakemac53 deleted the cleanup-extensions-logic branch October 4, 2025 04:19

thacio added a commit to thacio/auditaria that referenced this pull request Oct 7, 2025

Merge Commit '7f8537a': Cleanup extension update logic (google-gemini…

34a91ff

…#10514)

chrstnb added a commit that referenced this pull request Oct 7, 2025

Patch #10628 and #10514 into v0.8.0 preview (#10646)

aaca0bf

Co-authored-by: Jacob MacDonald <jakemac@google.com> Co-authored-by: Adam Weidman <65992621+adamfweidman@users.noreply.github.com>

giraffe-tree pushed a commit to giraffe-tree/gemini-cli that referenced this pull request Oct 10, 2025

Cleanup extension update logic (google-gemini#10514)

7d7a165

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Cleanup extension update logic#10514

Cleanup extension update logic#10514
jakemac53 merged 6 commits intomainfrom
cleanup-extensions-logic

jakemac53 commented Oct 3, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Oct 3, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 3, 2025 •

edited

Loading

Uh oh!

jakemac53 Oct 3, 2025

Uh oh!

jacob314 Oct 3, 2025 •

edited

Loading

Uh oh!

jakemac53 Oct 4, 2025

Uh oh!

jakemac53 Oct 4, 2025

Uh oh!

Uh oh!

jacob314 left a comment

Uh oh!

jacob314 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

jakemac53 commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TLDR

Dive deeper

Testing Matrix

Linked issues / bugs

Uh oh!

gemini-code-assist bot commented Oct 3, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakemac53 Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

jacob314 Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jakemac53 Oct 4, 2025

Choose a reason for hiding this comment

Uh oh!

jakemac53 Oct 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jacob314 left a comment

Choose a reason for hiding this comment

Uh oh!

jacob314 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jakemac53 commented Oct 3, 2025 •

edited

Loading

github-actions bot commented Oct 3, 2025 •

edited

Loading

jacob314 Oct 3, 2025 •

edited

Loading