Skip to content

fix(a2a-server): fix grammar typos in task.ts comments#14372

Closed
Viktor286 wants to merge 2 commits intogoogle-gemini:mainfrom
Viktor286:fix/typos-in-task-comments
Closed

fix(a2a-server): fix grammar typos in task.ts comments#14372
Viktor286 wants to merge 2 commits intogoogle-gemini:mainfrom
Viktor286:fix/typos-in-task-comments

Conversation

@Viktor286
Copy link
Contributor

@Viktor286 Viktor286 commented Dec 2, 2025

Summary

Fix three grammar and spelling typos in comments within the a2a-server task.ts file. This is a documentation-only improvement with no functional changes.

Details

This PR fixes three typos in code comments:

  • Line 741: "presesent" → "present"
  • Lines 859 & 899: "what it mean" → "what it means"

These are comment-only changes with zero impact on runtime behavior. The fixes improve code readability and maintain professional documentation standards.

Related Issues

Related to code quality improvements. No specific issue was filed for these typos.

How to Validate

  1. Review the git diff to confirm only comment text has changed:
    git diff main...fix/typos-in-task-comments packages/a2a-server/src/agent/task.ts
    
  2. Verify the file still compiles without errors:
    npm run build --workspace @google/gemini-cli-a2a-server
  3. Confirm existing tests pass unchanged (since no logic was modified):
    npm run test --workspace @google/gemini-cli-a2a-server

Expected result: All tests pass with no changes to functionality.

  1. npm run preflight executes successfully

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@Viktor286 Viktor286 requested a review from a team as a code owner December 2, 2025 16:18
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Viktor286, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on minor textual improvements within the task.ts file of the a2a-server package. It addresses grammatical typos in comments, enhancing the overall clarity and professionalism of the codebase's internal documentation without altering any functional logic.

Highlights

  • Grammar Correction: Corrected a typo from "presesent" to "present" in a comment describing the handling of an edit tool call payload.
  • TODO Comment Clarity: Updated the grammar in two TODO comments, changing "it mean to have" to "it means to have" for improved readability and clarity.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes several grammatical typos in comments within packages/a2a-server/src/agent/task.ts. These changes improve code readability and are well-contained. In accordance with the request to only provide feedback on high or critical severity issues, I have no specific review comments. The changes are good to merge.

@jackwotherspoon
Copy link
Contributor

Looks like there may be some conflicts on this

@jackwotherspoon
Copy link
Contributor

will merge one conflicts are resolved

@gemini-cli gemini-cli bot added the status/need-issue Pull requests that need to have an associated issue. label Jan 7, 2026
@bdmorgan
Copy link
Collaborator

Hi @Viktor286, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Jan 24, 2026

Hi there! Thank you for your contribution to Gemini CLI.

To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md.

This pull request is being closed because it is not currently linked to an issue. You can easily reopen this PR once you have linked it to an issue.

How to link an issue:
Add a keyword followed by the issue number (e.g., Fixes #123) in the description of your pull request. For more details, see the GitHub Documentation.

Thank you for your understanding and for being a part of our community!

@gemini-cli gemini-cli bot closed this Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants