Skip to content

fix .env check#123

Merged
olcan merged 1 commit intomainfrom
fix_dot_env_check
Apr 22, 2025
Merged

fix .env check#123
olcan merged 1 commit intomainfrom
fix_dot_env_check

Conversation

@olcan
Copy link
Contributor

@olcan olcan commented Apr 22, 2025

No description provided.

@olcan olcan merged commit a792c4a into main Apr 22, 2025
2 checks passed
@olcan olcan deleted the fix_dot_env_check branch April 22, 2025 21:31
keithballinger pushed a commit that referenced this pull request Jun 13, 2025
@olcan @keithballinger
fix .env check (#123)
d0234a2
yaleh pushed a commit to yaleh/gemini-cli that referenced this pull request Jun 29, 2025
@olcan
fix .env check (google-gemini#123)
efdff51
viridivn pushed a commit to viridivn/gemini-cli that referenced this pull request Jun 29, 2025
@olcan
fix .env check (google-gemini#123)
f79add8
FradSer added a commit to FradSer/gemini-cli that referenced this pull request Jul 1, 2025
@FradSer
fix: make footer validation more flexible for AI-generated content
aed5b13 
Replace rigid footer format validation with permissive approach:

Removed Strict Validations:
- No longer enforce exact patterns for issue references (e.g., 'Fixes google-gemini#123')
- No longer require specific Co-authored-by format
- Allow AI to use semantically correct alternatives

Kept Essential Validations:
- Reject extremely long footer lines (>200 chars) that indicate parsing errors
- Catch empty BREAKING CHANGE declarations
- Maintain basic structural sanity checks

Benefits:
- AI can use natural language variations like 'Fixes issue google-gemini#123' or 'Breaking change: ...'
- Semantically correct footers are accepted regardless of exact format
- Still protects against malformed content and parsing errors
- More user-friendly for AI-generated commit messages

Added test case demonstrating acceptance of flexible footer formats
that are semantically correct but don't match rigid patterns.

This prevents valid AI-generated footers from being unnecessarily rejected
while maintaining protection against obvious errors.
@gemini-cli gemini-cli bot added kind/enhancement priority/p1 Important and should be addressed in the near term. labels Jul 30, 2025
zapabob pushed a commit to zapabob/gemini-cli that referenced this pull request Aug 1, 2025
feat: グローバルインストール機能と改善点の完全実装
338fe7b 
 主要機能:
- グローバルインストールスクリプト (install-global.js)
- 自然言語CLIエントリーポイント (naturalLanguageCli.js)
- アンインストールスクリプト (uninstall-global.js)
- バージョン管理機能強化 (version-manager.js)
- 自動更新機能 (auto-updater.js)
- 詳細エラーハンドラー (error-handler.js)
- プログレスバー機能 (progress-bar.js)

 セキュリティ機能:
- 電源断保護機能 (5分間隔自動保存)
- 緊急保存機能 (Ctrl+C対応)
- バックアップローテーション (最大10個)
- セッション管理 (固有ID追跡)
- リカバリーシステム (前回セッション復旧)

 追加npmスクリプト (14個):
- install:global, uninstall:global
- version:current, version:update, version:check, version:changelog
- update:check, update:auto, update:settings, update:history
- error:analyze, error:system-info
- progress:demo

 技術的改善:
- Commanderからyargsへの移行
- 型安全性の向上
- エラー分類システム (7種類)
- セマンティックバージョニング対応
- 24時間間隔自動更新チェック

 テスト完了:
- グローバルインストール成功
- gemini/gemini-naturalコマンド動作確認
- 全改善点機能動作確認
- 電源断保護機能動作確認

Closes: google-gemini#123
Related: google-gemini#456
@hoteye hoteye mentioned this pull request Sep 16, 2025
Closed
@hoteye hoteye mentioned this pull request Sep 17, 2025
Closed
hoteye added a commit to hoteye/gemini-cli that referenced this pull request Sep 17, 2025
@hoteye
fix: restore PR description parsing in automated triage script
a04f936 
Fixes google-gemini#8522

This commit restores comprehensive PR description parsing that was
accidentally removed in PR google-gemini#7698. The triage script now properly
detects issue references in PR descriptions using multiple patterns:

1. Direct references like "google-gemini#123"
2. Keyword patterns like "Closes google-gemini#123", "Fixes google-gemini#456", "Resolves google-gemini#789"
3. Fallback to GitHub's closingIssuesReferences API as last resort

Without this fix, ALL PRs were incorrectly labeled with status/need-issue
because the script could only detect GitHub's automatically detected
closing references, missing many valid manual references in descriptions.

The regression was introduced when PR description parsing logic was
removed, leaving only the GitHub API fallback which has limited coverage.
hoteye added a commit to hoteye/gemini-cli that referenced this pull request Sep 17, 2025
@hoteye
improve: reorder issue reference detection for better accuracy
e473061 
Reorders pattern matching from most specific to least specific:

1. Keyword patterns (Closes/Fixes/Resolves google-gemini#123) - MOST SPECIFIC
2. GitHub API closingIssuesReferences - MEDIUM SPECIFICITY
3. Direct references (google-gemini#123) - LEAST SPECIFIC (fallback only)

This prevents incorrect matching when PR descriptions contain both
casual references and explicit closing statements.

Example improvement:
  PR body: "Related to google-gemini#100. Closes google-gemini#200."
  Before: Would incorrectly match google-gemini#100
  After:  Correctly matches google-gemini#200

Addresses code review feedback from @gemini-code-assist.
hoteye added a commit to hoteye/gemini-cli that referenced this pull request Sep 17, 2025
@hoteye
fix: remove overly broad issue reference pattern (google-gemini#8531)
ccc4bed 
Remove Pattern 3 (direct google-gemini#123 references) as suggested by @srithreepo
to avoid false positives where issue numbers are mentioned but not
actually being resolved.

Now only uses:
- Pattern 1: Explicit closes/fixes/resolves keywords (most reliable)
- Pattern 2: GitHub's closingIssuesReferences API (fallback)

This prevents adding status/need-issue label when PRs mention
issues like 'Issue #xyz introduced this bug' while still catching
legitimate issue links.
hoteye added a commit to hoteye/gemini-cli that referenced this pull request Sep 17, 2025
@hoteye
fix: remove invalid closingIssuesReferences API call
07a1c1d 
- Remove non-existent closingIssuesReferences field query
- Replace with direct google-gemini#123 pattern matching as Pattern 2
- Improve script reliability and reduce API calls
hoteye added a commit to hoteye/gemini-cli that referenced this pull request Sep 17, 2025
@hoteye
fix: remove overly broad google-gemini#123 pattern to avoid false pos…
21e4beb 
…itives

Per feedback from @srithreepo, remove direct google-gemini#123 pattern matching
to avoid incorrectly detecting issue references in cases like:
'Issue google-gemini#123 introduced this bug' which should still get needs-issue label.

Now only detects explicit closing keywords:
- Closes google-gemini#123
- Fixes google-gemini#456
- Resolves google-gemini#789
hoteye added a commit to hoteye/gemini-cli that referenced this pull request Sep 19, 2025
@hoteye
feat(.github): Add GitHub issue URI support to PR triage script
a0fb657 
- Support full GitHub issue URIs in addition to #<number> format
- Maintains backward compatibility with keyword + #number priority
- Falls back to URI detection when no keyword-based references found
- Addresses feedback from jakemac53 in PR review comments

Examples of supported formats:
- Closes google-gemini#123 (existing)
- https://github.com/owner/repo/issues/456 (new)
hackeraum248-eng added a commit to hackeraum248-eng/gemini-cli that referenced this pull request Sep 25, 2025
@hackeraum248-eng
Main
51bc8c3 
## TLDR

<!-- Add a brief description of what this pull request changes and why and any important things for reviewers to look at -->

## Dive Deeper

<!-- more thoughts and in-depth discussion here -->

## Reviewer Test Plan

<!-- when a person reviews your code they should ideally be pulling and running that code. How would they validate your change works and if relevant what are some good classes of example prompts and ways they can exercise your changes -->

## Testing Matrix

<!-- Before submitting please validate your changes on as many of these options as possible -->

|          | 🍏  | 🪟  | 🐧  |
| -------- | --- | --- | --- |
| npm run  | ❓  | ❓  | ❓  |
| npx      | ❓  | ❓  | ❓  |
| Docker   | ❓  | ❓  | ❓  |
| Podman   | ❓  | -   | -   |
| Seatbelt | ❓  | -   | -   |

## Linked issues / bugs

<!--
Link to any related issues or bugs.

**If this PR fully resolves the issue, use one of the following keywords to automatically close the issue when this PR is merged:**

- Closes #<issue_number>
- Fixes #<issue_number>
- Resolves #<issue_number>

*Example: `Resolves google-gemini#123`*

**If this PR is only related to an issue or is a partial fix, simply reference the issue number without a keyword:**

*Example: `This PR makes progress on google-gemini#456` or `Related to google-gemini#789`*
-->
@github-actions
Copy link

github-actions bot commented Oct 31, 2025

❌ Patch creation failed!

There was an error creating the patch release.

🔍 Troubleshooting:

  • Check the workflow logs for detailed error information
  • Verify the commit SHA is valid and accessible
  • Ensure you have permissions to create branches and PRs

🔗 Links:

@github-actions
Copy link

github-actions bot commented Oct 31, 2025

❌ Patch Release Failed!

📋 Details:

  • Version: 0.0.777777777779
  • Channel: stable
  • Error: The patch release workflow encountered an error

🔍 Next Steps:

  1. Check the workflow logs for detailed error information
  2. The maintainers have been notified via automatic issue creation
  3. You may need to retry the patch once the issue is resolved

🔗 Troubleshooting:

This was referenced Jan 24, 2026
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
bdmorgan added a commit that referenced this pull request Jan 24, 2026
@bdmorgan
feat(workflow): expand linked-issue detection to include soft mention…
2c3d4d0 
…s (e.g. Related to #123)
bdmorgan added a commit that referenced this pull request Jan 24, 2026
@bdmorgan
feat(workflow): expand linked-issue detection to include soft mention…
91a72d5 
…s (e.g. Related to #123)
@appsforartists appsforartists mentioned this pull request Feb 1, 2026
Open
@abhipatel12 abhipatel12 mentioned this pull request Feb 6, 2026
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@anowardear062-svg anowardear062-svg anowardear062-svg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

priority/p1 Important and should be addressed in the near term.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@olcan @anowardear062-svg