Skip to content

do not prepend ./ unless missing#200

Merged
olcan merged 2 commits intomainfrom
dir_prefix_fix
Apr 28, 2025
Merged

do not prepend ./ unless missing#200
olcan merged 2 commits intomainfrom
dir_prefix_fix

Conversation

@olcan
Copy link
Contributor

@olcan olcan commented Apr 28, 2025

No description provided.

@olcan olcan merged commit 6703b37 into main Apr 28, 2025
3 checks passed
@olcan olcan deleted the dir_prefix_fix branch April 28, 2025 18:07
@olcan olcan mentioned this pull request Apr 28, 2025
keithballinger pushed a commit that referenced this pull request Jun 13, 2025
* do not prepend ./ unless missing
* Merge remote-tracking branch 'origin/main' into dir_prefix_fix
yaleh pushed a commit to yaleh/gemini-cli that referenced this pull request Jun 29, 2025
* do not prepend ./ unless missing

* Merge remote-tracking branch 'origin/main' into dir_prefix_fix
viridivn pushed a commit to viridivn/gemini-cli that referenced this pull request Jun 29, 2025
* do not prepend ./ unless missing

* Merge remote-tracking branch 'origin/main' into dir_prefix_fix
hoteye added a commit to hoteye/gemini-cli that referenced this pull request Sep 17, 2025
Reorders pattern matching from most specific to least specific:

1. Keyword patterns (Closes/Fixes/Resolves google-gemini#123) - MOST SPECIFIC
2. GitHub API closingIssuesReferences - MEDIUM SPECIFICITY
3. Direct references (google-gemini#123) - LEAST SPECIFIC (fallback only)

This prevents incorrect matching when PR descriptions contain both
casual references and explicit closing statements.

Example improvement:
  PR body: "Related to google-gemini#100. Closes google-gemini#200."
  Before: Would incorrectly match google-gemini#100
  After:  Correctly matches google-gemini#200

Addresses code review feedback from @gemini-code-assist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant