Revert braces in Dockerfile#100
Closed
sethtroisi wants to merge 2 commits intogoogle-gemini:mainfrom
sethtroisi:main
Closed
Revert braces in Dockerfile#100sethtroisi wants to merge 2 commits intogoogle-gemini:mainfrom sethtroisi:main
sethtroisi wants to merge 2 commits intogoogle-gemini:mainfrom
sethtroisi:main
Conversation
NTaylorMullen
approved these changes
Apr 21, 2025
Collaborator
NTaylorMullen
left a comment
NTaylorMullen
left a comment
There was a problem hiding this comment.
Oh interesting, didn't know that!
rakyll
approved these changes
Apr 21, 2025
Collaborator
|
@sethtroisi I just saw you got blocked and had to update your branch. I've gone ahead and unrequire that check |
Contributor
Author
|
looks like this was already fixed by #97 |
hoteye
added a commit
to hoteye/gemini-cli
that referenced
this pull request
Sep 17, 2025
Reorders pattern matching from most specific to least specific: 1. Keyword patterns (Closes/Fixes/Resolves google-gemini#123) - MOST SPECIFIC 2. GitHub API closingIssuesReferences - MEDIUM SPECIFICITY 3. Direct references (google-gemini#123) - LEAST SPECIFIC (fallback only) This prevents incorrect matching when PR descriptions contain both casual references and explicit closing statements. Example improvement: PR body: "Related to google-gemini#100. Closes google-gemini#200." Before: Would incorrectly match google-gemini#100 After: Correctly matches google-gemini#200 Addresses code review feedback from @gemini-code-assist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brace expansion is supported by docker but not podman. I only tested my first change (#95) with
dockerbefore I hadpodmansetup on my cloudtop.