Skip to content

feat: add /view command to open last result in external editor#14894

Closed
sotopelaez092-star wants to merge 3 commits intogoogle-gemini:mainfrom
sotopelaez092-star:claude/feat-view-command-01QmKYj6oyJozV4XWA9FKmA1
Closed

feat: add /view command to open last result in external editor#14894
sotopelaez092-star wants to merge 3 commits intogoogle-gemini:mainfrom
sotopelaez092-star:claude/feat-view-command-01QmKYj6oyJozV4XWA9FKmA1

Conversation

@sotopelaez092-star
Copy link

Summary

Changes

  • Add openInEditor() and getOpenCommand() functions to editor.ts
  • Create viewCommand.ts with /view slash command implementation
  • Add comprehensive tests (46 new test cases)

Test plan

  • Unit tests pass for openInEditor and getOpenCommand
  • Unit tests pass for viewCommand
  • Build succeeds

Implements Issue google-gemini#14862. The /view command saves the last AI response
to a temporary markdown file and opens it in the user's configured
editor, making it easier to view, copy, and work with longer responses.

- Add openInEditor() and getOpenCommand() functions to editor.ts
- Create viewCommand.ts with /view slash command implementation
- Register viewCommand in BuiltinCommandLoader.ts
- Add comprehensive tests for all new functionality
@sotopelaez092-star sotopelaez092-star requested a review from a team as a code owner December 10, 2025 15:26
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @sotopelaez092-star, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a new /view slash command, allowing users to seamlessly open the most recent AI-generated output in their preferred external editor. This feature streamlines the workflow by enabling quick review and manipulation of AI responses using familiar tools, addressing the need to easily access and work with generated content outside the CLI environment.

Highlights

  • New /view Command: Introduces a slash command to open the last AI response in an external editor.
  • Editor Integration: Adds core utility functions (openInEditor, getOpenCommand) to handle opening files in various external editors.
  • Comprehensive Testing: Includes extensive unit tests (46 new cases) for the new command and editor utilities.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new /view command to open the last AI response in an external editor. The implementation is well-structured, with new core utilities for opening files in editors and a dedicated command file. The test coverage is comprehensive, covering various scenarios for the new command and utility functions.

My review focuses on a couple of high-severity issues. There's a resource leak where temporary files created by the /view command are not deleted, which I've provided a fix for. Additionally, I've found a bug where the openInEditor utility can fail silently, leading to incorrect behavior, and I've suggested a fix for that along with an update to the corresponding test case.

- Add temp file cleanup in finally block to prevent resource leak
- Change openInEditor to throw error instead of returning silently
- Update tests to verify cleanup and error throwing behavior
@SuperrMurlocc
Copy link

Works like a charm, this is precisely what I asked for in issue: #14862. Thank you!

Copy link

@LIHUA919 LIHUA919 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exceptional readability here. I really appreciate how the complex logic was broken down into small, digestible helper functions. It flows like prose. 👏

@gemini-cli gemini-cli bot added status/need-issue Pull requests that need to have an associated issue. priority/p2 Important but can be addressed in a future release. area/core Issues related to User Interface, OS Support, Core Functionality and removed status/need-issue Pull requests that need to have an associated issue. labels Jan 7, 2026
@bdmorgan
Copy link
Collaborator

Hi @sotopelaez092-star, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Jan 24, 2026

Hi there! Thank you for your contribution to Gemini CLI.

To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md.

This pull request is being closed because it is not currently linked to an issue. You can easily reopen this PR once you have linked it to an issue.

How to link an issue:
Add a keyword followed by the issue number (e.g., Fixes #123) in the description of your pull request. For more details, see the GitHub Documentation.

Thank you for your understanding and for being a part of our community!

@gemini-cli gemini-cli bot closed this Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality priority/p2 Important but can be addressed in a future release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants