Conversation
Summary of ChangesHello @bl-ue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new /rename slash command to rename the current session. The implementation is mostly correct and includes appropriate tests and refactoring. However, I've found a critical race condition in the renameCommand implementation. Instantiating a new ChatRecordingService can lead to data loss if the command is executed while a model response is being streamed and recorded. My review comment details this issue and suggests an architectural change to resolve it by using a single shared service instance.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds a /rename command to allow users to rename the current session. The implementation looks good, introducing a new displayName field in the session record and updating various parts of the CLI to use it. I've found one issue where the new command fails silently if the chatRecordingService is not available, which I've commented on with a suggestion for a fix.
0466dcf to
0be4803
Compare
|
@bl-ue looks like some merge conflicts due to my optimizations to session summary. mind resolving them? 😄 |
jackwotherspoon
left a comment
There was a problem hiding this comment.
Can sessions be resumed via display name?
Would it make sense to also allow resuming via name if the user has explicitly renamed it?
|
Currently no, sessions can only be resumed by ID or index via |
# Conflicts: # packages/core/src/services/sessionSummaryUtils.test.ts # packages/core/src/services/sessionSummaryUtils.ts
|
@bl-ue its possible to show them as some-name-set-by-user (id: actual-id) |
|
Hi @linegel, I'm not sure what you're asking—will you please clarify? @jackwotherspoon Conflicts resolved. |
It was suggestion following resuming by name discussion, so that if name is shared by more than one session, the choice can be made based on id/time of last interaction |
|
@linegel Okay, I see what you mean. When you run So if I'm understanding you correctly, it already works like you're suggesting. I guess we can make it possible to resume a session by its manually-set title, and if there happens to be multiple sessions with the specified title, we'll just resume the most recent one. Now that I think about it, if session names are short slugs like |
@bl-ue this is the exact scenario i was invisioning 😄 I often bounce between multiple features/branchess for Gemini CLI at once. I would love to name my sessions the same thing as my branches. That way whatever branch i am on i can just |
|
@jackwotherspoon @linegel Implement and ready for review. It's now possible to resume a session by index, ID, and manually-assigned name. If there are multiple sessions with the same manual ID, the most recent one is selected. |
|
Hi @bl-ue, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
|
Hi there! Thank you for your contribution to Gemini CLI. To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md. This pull request is being closed because it is not currently linked to an issue. You can easily reopen this PR once you have linked it to an issue. How to link an issue: Thank you for your understanding and for being a part of our community! |
|
Hi there! Thank you for your contribution to Gemini CLI. We really appreciate the time and effort you've put into this pull request. To keep our backlog manageable and ensure we're focusing on current priorities, we are closing pull requests that haven't seen maintainer activity for 30 days. Currently, the team is prioritizing work associated with 🔒 maintainer only or help wanted issues. If you believe this change is still critical, please feel free to comment with updated details. Otherwise, we encourage contributors to focus on open issues labeled as help wanted. Thank you for your understanding! |
Summary
Adds a
/renameslash command to rename the current session.Details
Only works in interactive sessions with at least one user message sent.
Related Issues
How to Validate
Pre-Merge Checklist