Skip to content

fix: correct 6 typos in codebase#14974

Closed
kuishou68 wants to merge 5 commits intogoogle-gemini:mainfrom
kuishou68:fix/typos-1765504819869
Closed

fix: correct 6 typos in codebase#14974
kuishou68 wants to merge 5 commits intogoogle-gemini:mainfrom
kuishou68:fix/typos-1765504819869

Conversation

@kuishou68
Copy link
Contributor

@kuishou68 kuishou68 commented Dec 12, 2025

Summary

This PR fixes 6 typos found in the codebase.

Changes

  • occassionallyoccasionally in .gemini/commands/review-frontend.toml:67
  • shoulshould in packages/cli/src/ui/components/__snapshots__/LoadingIndicator.test.tsx.snap:4
  • highlightinhighlighting in packages/cli/src/ui/components/messages/__snapshots__/GeminiMessage.test.tsx.snap:17
  • seconsecond in packages/cli/src/ui/components/shared/text-buffer.test.ts:783
  • seviceservice in packages/core/src/availability/policyHelpers.ts:87
  • valluesvalues in packages/core/src/utils/customHeaderUtils.ts:8

Generated by RepoPolisher

Generated by RepoPolisher
@kuishou68 kuishou68 requested a review from a team as a code owner December 12, 2025 02:05
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @kuishou68, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the overall code quality and maintainability by systematically identifying and correcting numerous typographical errors throughout the codebase. The changes span across documentation, test files, and core logic, ensuring that the project's text is accurate and professional. This cleanup contributes to a more reliable and easier-to-understand codebase for all developers.

Highlights

  • Typo Corrections: Addressed and fixed 18 spelling errors across various files, enhancing code readability and consistency.
  • Snapshot Updates: Updated UI component snapshot tests to reflect corrected text, ensuring tests remain accurate with the improved spelling.
  • Improved Clarity: Corrected typos in comments, variable names, and test descriptions, such as 'sevice' to 'service' and 'Optin' to 'Option', for better understanding.
Ignored Files
  • Ignored by pattern: .gemini/** (1)
    • .gemini/commands/review-frontend.toml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

…ion to freeTierDataCollectionOptin in code assist types.
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix 18 typos across the codebase. While several typos in comments and variable names have been corrected successfully, I've found a few critical issues where the automated fix was incorrect. Specifically, in several test snapshot files, the corrected words have extra characters (e.g., shouldddddd instead of should), which will break the tests. There is also a case where a variable was renamed, but its usage was not, leading to a ReferenceError. Another change in a test file seems to weaken the test's intent. Please review the suggested changes to address these critical problems.

I am having trouble creating individual review comments. Click here to see my feedback.

packages/cli/src/ui/components/snapshots/LoadingIndicator.test.tsx.snap (4-5)

critical

The typo fix from shoul to shouldddddd is incorrect. It seems you intended to change it to should. This will cause the snapshot test to fail.

"MockRespondin This is an extremely long loading phrase that should… (esc to
gSpinner                                                           cancel, 5s)"

packages/cli/src/ui/components/messages/snapshots/GeminiMessage.test.tsx.snap (17)

critical

The typo fix from highlightin to highlightingggggg is incorrect. It should be highlighting.

exports[`<GeminiMessage /> - Raw Markdown Display Snapshots > renders with renderMarkdown=false '(raw markdown with syntax highlighting…' 1`] = `

packages/cli/src/ui/components/shared/text-buffer.test.ts (783)

critical

The typo fix from secon to secondddddd is incorrect. It should be second.

        'second',

packages/core/src/utils/ignorePatterns.test.ts (23)

critical

The variable excluder was renamed to excluded, but it's still used as excluder on the next line. This will cause a ReferenceError. The original name excluder is also more descriptive for an instance of FileExclusions.

      const excluder = new FileExclusions();

packages/core/src/core/coreToolScheduler.test.ts (604)

high

The change from 'list_fils' to 'list_fills' seems incorrect for this test's purpose. The test is for typo suggestions, and 'list_fils' is a more realistic typo for 'list_files' than 'list_fills'. This change might weaken the test's intent. Please revert this change.

      const misspelledTool = scheduler.getToolSuggestion('list_fils', 1);

packages/core/src/core/coreToolScheduler.test.ts (614)

high

Similar to the previous comment, changing 'list_fils' to 'list_fills' seems to weaken the test for typo suggestions. Please consider reverting this change.

      const suggestionMultiple = scheduler.getToolSuggestion('list_fils');

@kuishou68 kuishou68 changed the title fix: correct 18 typos in codebase fix: correct 6 typos in codebase Dec 12, 2025
expect(result.current.allVisualLines).toEqual([
'line',
'one',
'secon',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't a typo. the d is wrapped to the following line.

@jacob314
Copy link
Contributor

Thanks for the typo fixes. Expect a few should be reverted as they aren't really typos and you should see tests failing with your changes.

@kuishou68
Copy link
Contributor Author

Thanks for the typo fixes. Expect a few should be reverted as they aren't really typos and you should see tests failing with your changes.

@jacob314 The fact is indeed as you said, it has been revised according to your opinions!

@gemini-cli gemini-cli bot added the status/need-issue Pull requests that need to have an associated issue. label Jan 7, 2026
@bdmorgan
Copy link
Collaborator

Hi @kuishou68, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Jan 24, 2026

Hi there! Thank you for your contribution to Gemini CLI.

To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md.

This pull request is being closed because it is not currently linked to an issue. You can easily reopen this PR once you have linked it to an issue.

How to link an issue:
Add a keyword followed by the issue number (e.g., Fixes #123) in the description of your pull request. For more details, see the GitHub Documentation.

Thank you for your understanding and for being a part of our community!

@gemini-cli gemini-cli bot closed this Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants