Add shortcuts hint and panel for discoverability#18035
Add shortcuts hint and panel for discoverability#18035jacob314 merged 36 commits intogoogle-gemini:mainfrom
Conversation
Summary of ChangesHello @LyalinDotCom, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user experience of the CLI by making its various commands and keybindings more accessible and discoverable. It introduces a persistent visual cue for shortcuts and a detailed, interactive panel that users can quickly summon and dismiss. This change aims to reduce the learning curve for new users and provide a convenient reference for experienced ones, ultimately streamlining interaction with the CLI. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This PR introduces a helpful shortcut discovery feature with a persistent hint and a toggleable panel. No vulnerabilities were found in the provided code changes. However, there are a couple of high-severity issues related to the feature's trigger logic and layout robustness that need to be addressed to ensure a smooth user experience and maintain layout consistency.
gemini-cli
bot
added
the
area/core
|
Hi there! Thank you for your contribution to Gemini CLI. We really appreciate the time and effort you've put into this pull request. To keep our backlog manageable and ensure we're focusing on current priorities, we are closing pull requests that haven't seen maintainer activity for 30 days. Currently, the team is prioritizing work associated with 🔒 maintainer only or help wanted issues. If you believe this change is still critical, please feel free to comment with updated details. Otherwise, we encourage contributors to focus on open issues labeled as help wanted. Thank you for your understanding! |
This fixes a bug where PRs from maintainers (or any PR) could be
immediately closed as stale even when just opened. The root causes:
1. If team member fetch failed silently, maintainerLogins was empty
2. lastActivity was initialized to epoch (1970), so any PR without
detected maintainer activity appeared 50+ years old
3. No minimum age check - PRs created today could be marked stale
Changes:
- Add explicit check to skip PRs created < 30 days ago from staleness
- Initialize lastActivity to PR creation date instead of epoch
- Improve logging for team fetch success/failure with details
- Add error logging for reviews/comments fetch failures
Fixes issue where PR #18035 from a maintainer was incorrectly closed.
|
Build failed: Build process failed (no specific link errors found). Check logs for details. |
2 similar comments
|
Build failed: Build process failed (no specific link errors found). Check logs for details. |
|
Build failed: Build process failed (no specific link errors found). Check logs for details. |
|
Build failed: Build process failed (no specific link errors found). Check logs for details. |
…Com/gemini-cli into show_help_questionmark
- Update LoadingIndicator tests to not pass currentLoadingPhrase when testing idle state, matching new component behavior that renders content when idle if there's a loading phrase or thought - Fix Composer test mock to use StreamingState.Idle instead of null - Add missing isConfigInitialized: true to Composer test mock
…taneously Move the shortcuts panel escape handling before the streaming state check so that pressing Escape when the panel is open only closes the panel. A second Escape press is then needed to cancel the operation.
|
Updated mock attached. Notes:
|
…w_help_questionmark
jacob314
left a comment
jacob314
left a comment
There was a problem hiding this comment.
I will follow up with some cleanup to remove text measurement logic that can be done in a more idiomatic way using ink.
4 participants
Summary
This PR adds an always-visible shortcuts hint and a toggleable shortcuts panel to improve command/key discoverability in the CLI input area.
Details
Related Issues
Related to #18034
How to Validate