Skip to content

chore: Update build-and-start script to support argument forwarding#18241

Merged
Abhijit-2592 merged 2 commits intomainfrom
abhijit-2592/build-and-run-enhance
Feb 6, 2026
Merged

chore: Update build-and-start script to support argument forwarding#18241
Abhijit-2592 merged 2 commits intomainfrom
abhijit-2592/build-and-run-enhance

Conversation

@Abhijit-2592
Copy link
Contributor

Summary

A simple change to the npm run build-and-start to allow passing command line arguments like npm run build-and-start -- --allowed-tools ls.

Details

Related Issues

How to Validate

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@Abhijit-2592 Abhijit-2592 requested a review from a team as a code owner February 3, 2026 22:39
@gemini-cli
Copy link
Contributor

gemini-cli bot commented Feb 3, 2026

Hi @Abhijit-2592, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Abhijit-2592, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a minor but significant improvement to the build-and-start npm script. By enabling argument forwarding, developers can now seamlessly pass custom options directly to the start command when executing npm run build-and-start, thereby streamlining the process of launching the application with specific configurations or tools.

Highlights

  • Script Argument Forwarding: The npm run build-and-start script has been updated to correctly forward command-line arguments to the underlying npm run start command, enhancing flexibility for development workflows.
Changelog
  • package.json
    • Modified the build-and-start script definition to include --, which ensures that any arguments provided to npm run build-and-start are properly passed on to the npm run start command.
Activity
  • No human activity (comments, reviews, or progress updates) has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the build-and-start npm script to correctly forward command-line arguments to the start script. The addition of -- ensures that all arguments, including those that could be interpreted as npm options (e.g., -v), are passed to the underlying start.js script. This is a good correctness fix that makes the convenience script more robust. The change is correct and I approve it.

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Size Change: -2 B (0%)

Total Size: 23.8 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 23.8 MB -2 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@gemini-cli gemini-cli bot added the priority/p1 Important and should be addressed in the near term. label Feb 3, 2026
@Abhijit-2592 Abhijit-2592 added this pull request to the merge queue Feb 6, 2026
Merged via the queue into main with commit ee68a10 Feb 6, 2026
26 checks passed
@Abhijit-2592 Abhijit-2592 deleted the abhijit-2592/build-and-run-enhance branch February 6, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority/p1 Important and should be addressed in the near term.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants