Conversation
|
Hi @Adib234, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello @Adib234, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the user experience of the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly removes an error message that was shown when using the /plan command without an approved plan. The change is straightforward and aligns with the goal of improving the user experience. I have one suggestion regarding test coverage to ensure this fix is robust and prevents future regressions.
I am having trouble creating individual review comments. Click here to see my feedback.
packages/cli/src/ui/commands/planCommand.test.ts (95-108)
While it's correct to remove this test for the old behavior, the new behavior (silently returning when no plan is found) is left untested. This creates a risk of future regressions where an unwanted message could be reintroduced.
Please add a new test case to verify that no feedback is emitted when /plan is run without an approved plan.
Here's an example of a test you could add:
it('should do nothing if no approved plan is found and already in plan mode', async () => {
vi.mocked(mockContext.services.config!.getApprovalMode).mockReturnValue(
ApprovalMode.PLAN,
);
vi.mocked(mockContext.services.config!.getApprovedPlanPath).mockReturnValue(
undefined,
);
if (!planCommand.action) throw new Error('Action missing');
await planCommand.action(mockContext, '');
expect(coreEvents.emitFeedback).not.toHaveBeenCalled();
});
|
Size Change: -133 B (0%) Total Size: 23.7 MB ℹ️ View Unchanged
|
gemini-cli
bot
added
the
priority/p1
2 participants
Summary
As title suggests
Details
Related Issues
Related to #17686, this is a follow up fix.
How to Validate
When in plan mode, it should show the approved plan if it exists. Otherwise nothing happens.
When not in plan mode and we run
/planwe should switch into plan mode.Screen.Recording.2026-02-04.at.2.28.46.PM.mov
Pre-Merge Checklist