Skip to content

Stop showing an error message in /plan #18333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jerop merged 1 commit into from
Feb 4, 2026
Merged

Stop showing an error message in /plan #18333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions packages/cli/src/ui/commands/planCommand.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,21 +92,6 @@ describe('planCommand', () => {
);
});

it('should show "No approved plan found" if no approved plan path in config', async () => {
vi.mocked(mockContext.services.config!.isPlanEnabled).mockReturnValue(true);
vi.mocked(mockContext.services.config!.getApprovedPlanPath).mockReturnValue(
undefined,
);

if (!planCommand.action) throw new Error('Action missing');
await planCommand.action(mockContext, '');

expect(coreEvents.emitFeedback).toHaveBeenCalledWith(
'error',
'No approved plan found. Please create and approve a plan first.',
);
});

it('should display the approved plan from config', async () => {
const mockPlanPath = '/mock/plans/dir/approved-plan.md';
vi.mocked(mockContext.services.config!.isPlanEnabled).mockReturnValue(true);
Expand Down
4 changes: 0 additions & 4 deletions packages/cli/src/ui/commands/planCommand.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,6 @@ export const planCommand: SlashCommand = {
const approvedPlanPath = config.getApprovedPlanPath();

if (!approvedPlanPath) {
coreEvents.emitFeedback(
'error',
'No approved plan found. Please create and approve a plan first.',
);
return;
}

Expand Down
Loading