feat(cli): make JetBrains warning more specific#19687
Conversation
|
Hi @jacob314, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello @jacob314, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the user experience by making terminal compatibility warnings more precise and actionable. Specifically, it targets JetBrains terminal users with a more detailed warning that is conditional on the alternate buffer mode and offers platform-specific external terminal suggestions. This ensures users receive relevant information only when necessary, guiding them towards better compatibility solutions. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the compatibility warnings, specifically for JetBrains terminals. The warning is now more specific, mentioning mouse scrolling issues, and is only displayed when using the alternate screen buffer. It also provides platform-specific recommendations for external terminals. The changes are well-implemented and propagated correctly through the components. The associated tests have been updated and refactored to use it.each, which improves their clarity and maintainability. I have one suggestion to improve the maintainability of the platform-specific terminal logic.
|
Size Change: +587 B (0%) Total Size: 25.2 MB ℹ️ View Unchanged
|
Make terminal recommendations platform specific.
b8ee104 to
b16e721
Compare
Summary
Fixes #19686