Make JetBrains terminal warning platform-specific

[yasuo72]

Fixes #19687

• Make JetBrains terminal warning recommend terminals based on OS (Windows Terminal on Windows, iTerm2/Terminal.app on macOS).
• Add/adjust tests for platform-specific recommendation strings.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello @yasuo72, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the user experience by making the JetBrains terminal compatibility warning more intelligent and helpful. Instead of a generic message, the warning now dynamically suggests appropriate alternative terminals based on the user's operating system, providing more relevant guidance and addressing potential rendering or scrolling issues more effectively.

Highlights

• Platform-Specific Terminal Recommendations: The JetBrains terminal warning now provides tailored recommendations based on the operating system. Users on Windows will be advised to use Windows Terminal, macOS users will see iTerm2 or Terminal.app, and Linux users will be recommended a native terminal emulator.
• Updated Test Coverage: New and adjusted tests have been added to ensure the correct platform-specific recommendation strings are displayed for the JetBrains terminal warning across different operating systems.

Changelog

• packages/core/src/utils/compatibility.test.ts
  • Added new test cases to verify the JetBrains terminal warning message for macOS, Windows, and Linux, ensuring platform-specific recommendations are correctly included.
  • Adjusted an existing test case to assert the presence of 'Windows Terminal' in the warning message when running on Windows.
• packages/core/src/utils/compatibility.ts
  • Implemented logic to detect the operating system (Windows, macOS, or Linux) within the isJetBrainsTerminal warning function.
  • Dynamically constructed the JetBrains terminal warning message to include OS-specific terminal recommendations (Windows Terminal, iTerm2/Terminal.app, or a native terminal emulator).

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces platform-specific recommendations for terminal emulators when a JetBrains IDE terminal is detected. The changes are well-implemented and include corresponding updates to the test suite to cover different operating systems. I've suggested a small refactoring to improve the maintainability of the platform detection logic. Overall, this is a good improvement.

[yasuo72]

Hi,
Could you please review this PR when you get a chance?
I’d really appreciate your feedback. Thanks!

[yasuo72]

hey any changes needed ??