Skip to content

Conversation

@fredrikaverpil
Copy link
Contributor

@fredrikaverpil fredrikaverpil commented Oct 24, 2025

Why this change?

Fix #379 - Service account is not actually optional, but it says so in the README.

What?

  • Add support for direct WIF my making access_token and gcp_access_token_scopes into configurable inputs.

Notes

  • This is not a backwards compatibility breaking change, as I added the current values into the new inputs' defaults.
  • Another approach could be to not introduce any new inputs, and instead have two variants of the authentication step; one that works like today, and one which doesn't set access_token if no service account was specified. This would require some minor changes to the WIF validation logic in the action.

@fredrikaverpil fredrikaverpil marked this pull request as ready for review October 24, 2025 13:42
@fredrikaverpil fredrikaverpil requested review from a team as code owners October 24, 2025 13:42
Copy link
Contributor

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @fredrikaverpil!

@jerop jerop merged commit 0f1a5b3 into google-github-actions:main Nov 7, 2025
7 checks passed
google-github-actions-bot added a commit that referenced this pull request Nov 21, 2025
## What's Changed
* feat: support direct wif by @fredrikaverpil in
#380
* feat(issue triage): Get all labels of the repository by @chouetz in
#346
* Prompt engineering for `gemini-scheduled-triage.toml`. by @joshualitt
in #356
* Sync `/examples` with `.github/` - refactor examples to also use
custom commands in prompts by @jerop in
#386
* chore: add support to use pnpm instead of npm for install by @dcreey
in #385
* feat(telemetry): set GHA_NAME dynamically from workflow by @MJjainam
in #390

## New Contributors
* @fredrikaverpil made their first contribution in
#380
* @chouetz made their first contribution in
#346
* @dcreey made their first contribution in
#385
* @MJjainam made their first contribution in
#390

**Full Changelog**:
v0.1.14...v0.1.15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Service Account is not optional

2 participants