-
Notifications
You must be signed in to change notification settings - Fork 193
Sync /examples with .github/ - refactor examples to also use custom commands in prompts
#386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🤖 Hi @jerop, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request effectively refactors the example workflows by separating the prompts into TOML files. This change significantly improves the maintainability and usability of the examples. The accompanying documentation and script changes are clear and well-executed.
🔍 General Feedback
- The refactoring to TOML files is a great improvement, making the workflow files cleaner and the prompts easier to manage.
- The documentation updates are comprehensive and provide clear instructions for users who want to customize the prompts.
…amples script - Add comprehensive documentation explaining TOML custom command files - Document how commands are copied from .github/commands/ to .gemini/commands/ - Add customization instructions for each workflow type (invoke, review, triage) - Update CONFIGURATION.md with new 'Custom Commands (TOML Files)' section - Update individual workflow READMEs with TOML file customization steps - Enhance generate-examples.sh to copy TOML files to example directories This change improves discoverability and usability by clearly documenting how users can customize prompts using TOML files instead of inline YAML. Note: Future work will include updating the /setup-github command upstream in the Gemini CLI to automatically copy TOML files when setting up workflows.
03965d6 to
9ee15b9
Compare
joshualitt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
## What's Changed * feat: support direct wif by @fredrikaverpil in #380 * feat(issue triage): Get all labels of the repository by @chouetz in #346 * Prompt engineering for `gemini-scheduled-triage.toml`. by @joshualitt in #356 * Sync `/examples` with `.github/` - refactor examples to also use custom commands in prompts by @jerop in #386 * chore: add support to use pnpm instead of npm for install by @dcreey in #385 * feat(telemetry): set GHA_NAME dynamically from workflow by @MJjainam in #390 ## New Contributors * @fredrikaverpil made their first contribution in #380 * @chouetz made their first contribution in #346 * @dcreey made their first contribution in #385 * @MJjainam made their first contribution in #390 **Full Changelog**: v0.1.14...v0.1.15
This change improves discoverability and usability by clearly documenting how users can customize prompts using TOML files instead of inline YAML.
Note: Future work will include updating the /setup-github command upstream in the Gemini CLI to automatically copy TOML files when setting up workflows - #378.
Fixes #377