Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: recommend Sifive August 2020 toolchain #339

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Conversation

danc86
Copy link
Collaborator

@danc86 danc86 commented Nov 15, 2021

Eventually we'll just use conda but in the meantime, update it.

@danc86 danc86 requested a review from alanvgreen November 15, 2021 00:45
@danc86
Copy link
Collaborator Author

danc86 commented Nov 15, 2021

Well, the docs build fails but the error is:

Exception occurred:
  File "/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/docutils/writers/html5_polyglot/__init__.py", line 445, in section_title_tags
    if (ids and self.settings.section_self_link
AttributeError: 'Values' object has no attribute 'section_self_link'

which according to sphinx-doc/sphinx#9825 seems to be because we are wrongly using docutils 0.18. So I guess it's probably broken for us on main too, not related to this PR.

Sphinx wants docutils < 0.18 because it seems docutils made some incompatible changes. However we have a somewhat older Sphinx and possibly it does not express the docutils < 0.18 version constraint so pip is giving us this incompatible mixture.

@danc86
Copy link
Collaborator Author

danc86 commented Nov 15, 2021

PR #340 should fix the doc build failure in CI.

@tcal-x
Copy link
Collaborator

tcal-x commented Nov 15, 2021

Hi @danc86 , #340 is merged, so can you rebase this to see if it now passes?

This gives us GCC 10.1 which produces faster code than 8.x. We can't use
the Sifive release of GCC 10.2 because it doesn't include rv32im.

Signed-off-by: Dan Callaghan <dcallagh@google.com>
@danc86
Copy link
Collaborator Author

danc86 commented Nov 15, 2021

Looks like this is all good now!

@danc86 danc86 merged commit 4481a18 into google:main Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants