Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: upgrade to Sphinx 4.3 #340

Merged
merged 1 commit into from
Nov 15, 2021
Merged

docs: upgrade to Sphinx 4.3 #340

merged 1 commit into from
Nov 15, 2021

Conversation

danc86
Copy link
Collaborator

@danc86 danc86 commented Nov 15, 2021

Trying to fix breakage in CI due to docutils 0.18 incompatibility.

Trying to fix breakage in CI due to docutils 0.18 incompatibility.

Signed-off-by: Dan Callaghan <dcallagh@google.com>
@danc86 danc86 requested a review from tcal-x November 15, 2021 10:30
@danc86
Copy link
Collaborator Author

danc86 commented Nov 15, 2021

The newer Sphinx works fine, and more importantly it constrains the version of docutils so that pip picks 0.17 as desired:

Collecting docutils<0.18,>=0.14
  Downloading docutils-0.17.1-py2.py3-none-any.whl (575 kB)

which lets the check-docs job pass in CI.

Copy link
Collaborator

@tcal-x tcal-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tcal-x tcal-x merged commit ca18eec into google:main Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants