-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Support MCP streamable http #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello @showenx here is a PR to implement streamable http MCPs, I added an new StreamableHTTPServerParams class as the current implementation of ADK uses isinstance() to determine the kind of client, so I did not want to derive too much. You can test and give me some feedback. |
the Basically using |
The modifications in my repo were in a feature branch, I just emerged them back to main to make the discussion easier. In fact mcp_toolset.py was updated, the two interfaces are in fact 90% similar. But I peferred keeping a consistent approach by creating a specific class. Tell me if you manage to test. |
is this the main branch? https://github.com/omarbenhamid/google-adk-python tried following, |
You're right thanks, just fixed it now. (before you needed to import from mcp_session manager, which was not the target) you can pull again. |
looking good, works for me on local build |
@omarbenhamid thank you for your understanding and fix:) |
Copybara import of the project: -- c5b9d49 by Omar BENHAMID <omar.benhamid@smart-gts.com>: feat: #479 support for streamable http MCP servers for MCPToolset -- 9431bc1 by Omar BENHAMID <omar.benhamid@smart-gts.com>: feat: #479 streamable http added to right package -- 8b4aabe by Omar BENHAMID <omar.benhamid@smart-gts.com>: feat: #479 streamable http : review feedbacks + sample agent COPYBARA_INTEGRATE_REVIEW=#650 from omarbenhamid:feature/mcp-streamable-http 625f028 PiperOrigin-RevId: 764419586
Copybara import of the project: -- c5b9d49 by Omar BENHAMID <omar.benhamid@smart-gts.com>: feat: google#479 support for streamable http MCP servers for MCPToolset -- 9431bc1 by Omar BENHAMID <omar.benhamid@smart-gts.com>: feat: google#479 streamable http added to right package -- 8b4aabe by Omar BENHAMID <omar.benhamid@smart-gts.com>: feat: google#479 streamable http : review feedbacks + sample agent COPYBARA_INTEGRATE_REVIEW=google#650 from omarbenhamid:feature/mcp-streamable-http 625f028 PiperOrigin-RevId: 764419586
seanzhou1023 when will this be released ? |
With
Streamable HTTP
protocol updatedhttps://modelcontextprotocol.io/specification/2025-03-26/basic/transports#streamable-http
Can we expand
SseServerParams
or add a new protocol type to support that?https://google.github.io/adk-docs/tools/mcp-tools/#step-1-attach-the-fastmcp-server-to-your-adk-agent-via-mcptoolset
The text was updated successfully, but these errors were encountered: