-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: Solving #479 - support for streamable http MCP server #650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Solving #479 - support for streamable http MCP server #650
Conversation
6f63e95
to
c5b9d49
Compare
Resolved merge conflicts with main branch again : @seanzhou1023 would you please review it before it conflicts again if you have the possibility ? |
@seanzhou1023 could you please review : conflicts resolved again. |
@DeanChensj @seanzhou1023 please inform me if I should keep maintaining this PR mergable to main or not. |
Hi ADK team, I also wonder when this PR will get merged. This PR will enable MCP server to be streamable http for our agent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you so much for contributing, generally looks good, could you please add a sample agent example to test this capability like :
https://github.com/google/adk-python/tree/main/contributing/samples/mcp_sse_agent
sorry, for the delay we were busy with Google I/O events. Thanks for your understanding. Your PR makes great sense to us :) |
@omarbenhamid sorry could you resolve the conflict ag and address the comment ? I can help approve and merge the PR today. I understand that it's annoying to resolve conflict ag and ag, do appreciate your contribution :) |
@seanzhou1023 no problem of course. I guess the I/O event is an important moment. I addressed the review issues and merged the upstream, this one was tough, as there was some refactoring to the MCP Session Manager but I guess it was the last one 😅. Thank you. |
Thank you for this contribution, this would really help me once merged & released. |
@omarbenhamid thank you for your understanding and fix:) |
@omarbenhamid could you run "./autoformat.sh" |
Copybara import of the project: -- c5b9d49 by Omar BENHAMID <omar.benhamid@smart-gts.com>: feat: #479 support for streamable http MCP servers for MCPToolset -- 9431bc1 by Omar BENHAMID <omar.benhamid@smart-gts.com>: feat: #479 streamable http added to right package -- 8b4aabe by Omar BENHAMID <omar.benhamid@smart-gts.com>: feat: #479 streamable http : review feedbacks + sample agent COPYBARA_INTEGRATE_REVIEW=#650 from omarbenhamid:feature/mcp-streamable-http 625f028 PiperOrigin-RevId: 764419586
PR merged in commit d232e62 |
Copybara import of the project: -- c5b9d49 by Omar BENHAMID <omar.benhamid@smart-gts.com>: feat: google#479 support for streamable http MCP servers for MCPToolset -- 9431bc1 by Omar BENHAMID <omar.benhamid@smart-gts.com>: feat: google#479 streamable http added to right package -- 8b4aabe by Omar BENHAMID <omar.benhamid@smart-gts.com>: feat: google#479 streamable http : review feedbacks + sample agent COPYBARA_INTEGRATE_REVIEW=google#650 from omarbenhamid:feature/mcp-streamable-http 625f028 PiperOrigin-RevId: 764419586
Added support for streamablehttp transport for MCP servers (issue #479).
This required also bumping to latest MCP python SDK release to 1.8.0.