Ensure compilation tests will run on JDK 16+. #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_362396186
branch
from
a0821d0 to
14ec090
Compare
As noted [here](google/compile-testing#222), the change of the default `--illegal-access` from `permit` to `deny` will cause compile-testing tests to fail by default, with messages like this: ``` class com.google.testing.compile.Parser (in unnamed module @0x4114d843) cannot access class com.sun.tools.javac.api.JavacTool (in module jdk.compiler) because module jdk.compiler does not export com.sun.tools.javac.api to unnamed module @0x4114d843 ``` We can work around that by supplying the necessary `--add-opens` flag to the JVM that runs the tests. RELNOTES=n/a PiperOrigin-RevId: 362531170
copybara-service
bot
force-pushed
the
test_362396186
branch
from
14ec090 to
cdbae35
Compare
aurambaj
added a commit
to pinterest/l10nmessages
that referenced
this pull request
Nov 14, 2023
When trying to run the test with Java 17, there was an issue with assertion accessing internal API. As reported in: google/compile-testing#222. As a fix, replaced asserts with plain text asserts, inspired by google/auto#1004 To be running the test on Java 17. Need to update the processor test to
aurambaj
added a commit
to pinterest/l10nmessages
that referenced
this pull request
Nov 15, 2023
When trying to run the test with Java 17, there was an issue with assertion accessing internal API. As reported in: google/compile-testing#222. As a fix, replaced asserts with plain text asserts, inspired by google/auto#1004 To be running the test on Java 17. Need to update the processor test to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure compilation tests will run on JDK 16+.
As noted here, the change of the default
--illegal-accessfrompermittodenywill cause compile-testing tests to fail by default, with messages like this:We can work around that by supplying the necessary
--add-opensflag to the JVM that runs the tests.RELNOTES=n/a