Access to compiler internal APIs will fail starting with JDK 16 #222

eamonnmcmanus · 2021-03-11T23:13:31Z

JDK 16 will change the default for the --illegal-access flag from permit to deny. This means that, by default, compile-testing tests will fail with messages like this:

class com.google.testing.compile.Parser (in unnamed module @0x4114d843) cannot access class
com.sun.tools.javac.api.JavacTool (in module jdk.compiler) because module jdk.compiler does not export
com.sun.tools.javac.api to unnamed module @0x4114d843

That can be worked around either by explicitly specifying, on the command line of the JVM running the tests, either --illegal-access=permit or --add-opens=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED. We should document that, and perhaps later find a way to make it unnecessary.

The text was updated successfully, but these errors were encountered:

As noted [here](google/compile-testing#222), the change of the default `--illegal-access` from `permit` to `deny` will cause compile-testing tests to fail by default, with messages like this: ``` class com.google.testing.compile.Parser (in unnamed module @0x4114d843) cannot access class com.sun.tools.javac.api.JavacTool (in module jdk.compiler) because module jdk.compiler does not export com.sun.tools.javac.api to unnamed module @0x4114d843 ``` We can work around that by supplying the necessary `--add-opens` flag to the JVM that runs the tests. RELNOTES=n/a PiperOrigin-RevId: 362396186

As noted [here](google/compile-testing#222), the change of the default `--illegal-access` from `permit` to `deny` will cause compile-testing tests to fail by default, with messages like this: ``` class com.google.testing.compile.Parser (in unnamed module @0x4114d843) cannot access class com.sun.tools.javac.api.JavacTool (in module jdk.compiler) because module jdk.compiler does not export com.sun.tools.javac.api to unnamed module @0x4114d843 ``` We can work around that by supplying the necessary `--add-opens` flag to the JVM that runs the tests. RELNOTES=n/a PiperOrigin-RevId: 362531170

…internal APIs on Java 16

ZacSweers · 2021-06-11T20:39:42Z

Just mentioning that the --illegal-access flag was removed in JDK 17, so any solution for this would likely need to use --add-opens

…internal APIs on Java 16

…ompiler internal APIs on Java 16" This reverts commit 008a719.

h908714124 · 2021-11-06T22:12:18Z

Consider deprecating methods containsElementsIn and hasSourceEquivalentTo in class JavaFileObjectSubject. These use Parser internally, which depends on forbidden Sun APIs. With some effort, it should be possible to rewrite affected tests and use method generatedSourceFile in class Compilation instead. This is the future-proof way to compare the generated source with expectations. See this commit for example.

almogtavor · 2022-09-24T23:55:06Z

@h908714124 is right, but as a workaround:

test {
    jvmArgs "--add-opens=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED"
    useJUnitPlatform()
}

would work

Additional `--add-exports` JVM args were needed for testing. See: google/compile-testing#222

mikewacker · 2023-05-08T05:31:58Z

@almogtavor Here's an updated workaround for Gradle:

test {
    useJUnitPlatform()

    // See: https://github.com/google/compile-testing/issues/222
    jvmArgs '--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED'
    jvmArgs '--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED'
    jvmArgs '--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED'
}

Notes:

You only need to use --add-exports, --add-opens is overkill.
As of release 0.20, two additional --add-exports are needed. See: cd2c0a8

xenoterracide · 2023-08-07T21:00:56Z

looks like I just hit this

    java.lang.IllegalAccessError: class com.google.testing.compile.Parser (in unnamed module @0x15bbf42f) cannot access class com.sun.tools.javac.util.Context (in module jdk.compiler) because module jdk.compiler does not export com.sun.tools.javac.util to unnamed module @0x15bbf42f
        at com.google.testing.compile.Parser.parse(Parser.java:63)
        at com.google.testing.compile.JavaFileObjectSubject.performTreeDifference(JavaFileObjectSubject.java:173)
        at com.google.testing.compile.JavaFileObjectSubject.hasSourceEquivalentTo(JavaFileObjectSubject.java:126)
        at com.xenoterracide.bygger.ClassAnnotationTest.testImmutable(ClassAnnotationTest.java:53)

xenoterracide · 2023-08-07T21:08:53Z

Here's the kotlin dsl (which is now the default) equivalent of the above

tasks.test.configure {
  useJUnitPlatform()

  // See: https://github.com/google/compile-testing/issues/222
  jvmArgs =listOf(
    "--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED",
    "--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED",
    "--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED"
  )

ChristophLoy · 2023-08-08T07:40:21Z

Here's the kotlin dsl (which is now the default) equivalent of the above

tasks.test.configure {
  useJUnitPlatform()

  // See: https://github.com/google/compile-testing/issues/222
  jvmArgs =listOf(
    "--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED",
    "--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED",
    "--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED"
  )

@xenoterracide This is not the same! By assigning the jvmArgs via the = operator, you remove all existing jvmArgs. The actual equivalent would be:

    jvmArgs("--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED")
    jvmArgs("--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED")
    jvmArgs("--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED")

When trying to run the test with Java 17, there was an issue with assertion accessing internal API. As reported in: google/compile-testing#222. As a fix, replaced asserts with plain text asserts, inspired by google/auto#1004 To be running the test on Java 17. Need to update the processor test to

The `--add-exports=` flags are required after https://openjdk.org/jeps/396 Related to #222 RELNOTES=n/a PiperOrigin-RevId: 592669579

The `--add-exports=` flags are required after https://openjdk.org/jeps/396 Related to #222 RELNOTES=n/a PiperOrigin-RevId: 592675658

copybara-service bot mentioned this issue Mar 11, 2021

Ensure compilation tests will run on JDK 16+. google/auto#1004

Merged

cgdecker added P3 type=defect Bug, not working as expected labels Mar 12, 2021

remkop added a commit to remkop/picocli that referenced this issue Mar 31, 2021

[google/compile-testing#222] add JVM arg to allow access to compiler …

e245450

…internal APIs on Java 16

duponter mentioned this issue Oct 11, 2021

Build does not work on JDK 17 making/yavi#176

Closed

h908714124 mentioned this issue Oct 13, 2021

Java 16 jbock-java/dapper#13

Closed

MarkoMackic pushed a commit to MarkoMackic/picocli that referenced this issue Oct 17, 2021

[google/compile-testing#222] add JVM arg to allow access to compiler …

008a719

…internal APIs on Java 16

MarkoMackic added a commit to MarkoMackic/picocli that referenced this issue Oct 17, 2021

Revert "[google/compile-testing#222] add JVM arg to allow access to c…

b6c2604

…ompiler internal APIs on Java 16" This reverts commit 008a719.

MarkoMackic added a commit to MarkoMackic/picocli that referenced this issue Oct 17, 2021

Revert "[google/compile-testing#222] add JVM arg to allow access to c…

2e4989e

…ompiler internal APIs on Java 16" This reverts commit 008a719.

nick-someone mentioned this issue Feb 22, 2022

build(ci): add JDK 17 to build matrix #298

Closed

remkop mentioned this issue Jan 26, 2023

picocli-annotation-processing-tests fail on Java 16+ remkop/picocli#1939

Closed

mikewacker mentioned this issue May 8, 2023

update compile-testing dep from 0.19 to 0.21.0 mikewacker/annotation-processor-example#49

Merged

mikewacker added a commit to mikewacker/annotation-processor-example that referenced this issue May 8, 2023

update compile-testing dep from 0.19 to 0.21.0 (#49)

95a1c4a

Additional `--add-exports` JVM args were needed for testing. See: google/compile-testing#222

lucasjoao mentioned this issue Dec 20, 2023

Preparação para a release de uma 1.0.0 laboratoriobridge/metafy#10

Merged

copybara-service bot pushed a commit that referenced this issue Dec 20, 2023

Fix CI for JDK 17+

3c93367

The `--add-exports=` flags are required after https://openjdk.org/jeps/396 Related to #222 RELNOTES=n/a PiperOrigin-RevId: 592669579

copybara-service bot mentioned this issue Dec 20, 2023

Fix CI for JDK 17+ #395

Merged

copybara-service bot pushed a commit that referenced this issue Dec 20, 2023

Fix CI for JDK 17+

e794c75

The `--add-exports=` flags are required after https://openjdk.org/jeps/396 Related to #222 RELNOTES=n/a PiperOrigin-RevId: 592675658

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Access to compiler internal APIs will fail starting with JDK 16 #222

Access to compiler internal APIs will fail starting with JDK 16 #222

eamonnmcmanus commented Mar 11, 2021

ZacSweers commented Jun 11, 2021

h908714124 commented Nov 6, 2021 •

edited

Loading

almogtavor commented Sep 24, 2022

mikewacker commented May 8, 2023

xenoterracide commented Aug 7, 2023

xenoterracide commented Aug 7, 2023

ChristophLoy commented Aug 8, 2023 •

edited

Loading

Access to compiler internal APIs will fail starting with JDK 16 #222

Access to compiler internal APIs will fail starting with JDK 16 #222

Comments

eamonnmcmanus commented Mar 11, 2021

ZacSweers commented Jun 11, 2021

h908714124 commented Nov 6, 2021 • edited Loading

almogtavor commented Sep 24, 2022

mikewacker commented May 8, 2023

xenoterracide commented Aug 7, 2023

xenoterracide commented Aug 7, 2023

ChristophLoy commented Aug 8, 2023 • edited Loading

h908714124 commented Nov 6, 2021 •

edited

Loading

ChristophLoy commented Aug 8, 2023 •

edited

Loading