Add basic materials scene renderer proj #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
footballhead
added a commit
to footballhead/bigwheels
that referenced
this pull request
Apr 15, 2024
I added an ArcballCamera to google#428 and noticed that it wasn't working as expected. ArcballCamera wasn't updating mViewProjectionMatrix after modifying mViewMatrix. This was causing the ArcballCamera to not work correctly when combined with the classes introduced in google#426.
footballhead
added a commit
to footballhead/bigwheels
that referenced
this pull request
Apr 15, 2024
I added an ArcballCamera to google#428 and noticed that it wasn't working as expected. ArcballCamera wasn't updating mViewProjectionMatrix after modifying mViewMatrix. This was causing the ArcballCamera to not work correctly when combined with the classes introduced in google#426.
apazylbe
pushed a commit
to footballhead/bigwheels
that referenced
this pull request
Apr 17, 2024
I added an ArcballCamera to google#428 and noticed that it wasn't working as expected. ArcballCamera wasn't updating mViewProjectionMatrix after modifying mViewMatrix. This was causing the ArcballCamera to not work correctly when combined with the classes introduced in google#426.
apazylbe
reviewed
May 8, 2024
footballhead
reviewed
May 8, 2024
footballhead
reviewed
May 8, 2024
footballhead
added a commit
to footballhead/bigwheels
that referenced
this pull request
Nov 6, 2024
Additions to google#428 to upstream: - ArcballCamera with user interaction - Use error material if no material loaded - LookAt+FitToCamera - Knob for gltf-scene-file - Some fix for anisotropy strength test re error material that I can't remember Test with: /build/bin/vk_gltf_scene_viewer --gltf-scene-file glTF-Sample-Assets/Models/AnisotropyStrengthTest/glTF/AnisotropyStrengthTest.gltf
footballhead
added a commit
to footballhead/bigwheels
that referenced
this pull request
Nov 6, 2024
Additions to google#428 to upstream: - ArcballCamera with user interaction - Use error material if no material loaded - LookAt+FitToCamera - Knob for gltf-scene-file - Some fix for anisotropy strength test re error material that I can't remember - Add ErrorVertex which only has in/out for positions - Only create shaders when the program uses them Test with: /build/bin/vk_gltf_scene_viewer --gltf-scene-file glTF-Sample-Assets/Models/AnisotropyStrengthTest/glTF/AnisotropyStrengthTest.gltf
apazylbe
force-pushed
the
addBasicMaterialsScene
branch
from
904c845 to
cd2b90e
Compare
apazylbe
force-pushed
the
addBasicMaterialsScene
branch
from
5fcc224 to
a20d9bc
Compare
footballhead
approved these changes
Nov 11, 2024
apazylbe
force-pushed
the
addBasicMaterialsScene
branch
from
71a479e to
09419a4
Compare
This demonstrates the scene renderer for basic materials Co-authored-by: Hai Nguyen <chaoticbob@users.noreply.github.com> Co-authored-by: Aliya Pazylbekova <apazylbe@users.noreply.github.com>
apazylbe
force-pushed
the
addBasicMaterialsScene
branch
from
09419a4 to
e633430
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This demonstrates the scene renderer for basic materials