Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove underscores from private property and method names #6548

Closed
rachel-fenichel opened this issue Oct 14, 2022 · 0 comments · Fixed by #8682
Closed

Remove underscores from private property and method names #6548

rachel-fenichel opened this issue Oct 14, 2022 · 0 comments · Fixed by #8682

Comments

@rachel-fenichel
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Why: to match the current google style guide and as part of checking tests for accesses to private properties.

Describe the solution you'd like

Rename only things that are private or otherwise internal to a file.
Anything with an underscore that is public or protected should be left alone to avoid API churn.

Describe alternatives you've considered

Could also rename protected stuff, but that has to be handled on a case-by-case basis.

Alternatively, we could leave these alone because they aren't part of the external API anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant